#6 Error when reading songs with relative timing

closed
nobody
None
5
2007-03-09
2007-03-06
Matias Holte
No

There is a bug when reading a song with relative timing (or there is something wrong with my song.txt file)
The song starts normally, but then the text is displayed so fast that it finishes in a couple of seconds, and the rest of the song is played without text.

When editing songs.cpp so that line 207 and 208 reads:
} else if(!strncmp("#RELATIVE:",buff,10)) {
if( buff[10] == 'y' || buff[10]=='Y')
(adding the test for uppercase Y), I dont have the problem anymore.

With this problem solved, it is a problem with the text going only slightly faster, and usually after each line. I wonder if this has something to do with songs.cpp, line 88 onwards
case '-' : {
while this case only reads one of the numbers, but should read the other one as well, and use this second number instead of the first one.

The reason why i didn't commit the changes directly, is that i compiled it for the first time today, and I'm still quite newbie on CVS.

The text file is taken from the 332 ultrastar song pack, and i can also upload the mp3 when nescessary.
Keep up the good work
Matias Holte

Discussion

  • Yoda-JM
    Yoda-JM
    2007-03-06

    • status: open --> pending
     
  • Yoda-JM
    Yoda-JM
    2007-03-06

    Logged In: YES
    user_id=1319653
    Originator: NO

    Hi,

    First half of the bug is fixed on CVS (thanks) it was a case problem. If a space is put the problem is still trigered (need to fix this).
    For the second part it is a larger problem because I haven't be careful while writing this part of code and the data structure should be change (shame on me).

    Vincent

    PS : btw you can subscribe to the -devel mailing list

     
  • Yoda-JM
    Yoda-JM
    2007-03-06

    Logged In: YES
    user_id=1319653
    Originator: NO

    Delete attachement since it contains copyrighted material (please send it by direct mail if asked)

     
  • Yoda-JM
    Yoda-JM
    2007-03-06

    • status: pending --> open
     
  • Yoda-JM
    Yoda-JM
    2007-03-09

    Logged In: YES
    user_id=1319653
    Originator: NO

    Hi,

    Fix has been commited on CVS (available in 10 minutes on anonymous CVS).
    It fixes relative songs with "- %d %d" sentence separator format delaying a little bit at each end of sentence.
    Please test and feedback.

    Vincent

     
  • Matias Holte
    Matias Holte
    2007-03-09

    Logged In: YES
    user_id=1718247
    Originator: YES

    I've tested it, and it works for me on at least 2 songs. Now it is only a constant short delay, but that is probably intentional (so to know a moment before when you are going to sing). Nice work :)

     
  • Yoda-JM
    Yoda-JM
    2007-03-09

    • status: open --> closed
     
  • Yoda-JM
    Yoda-JM
    2007-03-09

    Logged In: YES
    user_id=1319653
    Originator: NO

    Closed bug since the bug reported is fixed on CVS.
    Nevertheless sentence switching has not yet the same behavior as the windows ultrastar.