From: Stephane C. <ste...@ch...> - 2008-07-31 17:59:16
|
Hubert Figuiere wrote: > On Wed, 2008-07-30 at 23:26 +0200, Stephane Chauveau wrote: > >> Hello, >> >> During my vacations, I played a bit with DCRAW and I wrote an optimized >> version of the PPG interpolation function. >> >> My optimized code is almost twice as fast as the original dcraw code and >> can be found here: >> >> http://www.chauveau-central.net/pub/dcraw-optim-ppg.tar.gz >> >> The optimized code is almost totally independant of DCRAW so it should >> be quite easy to integrate in UFRAW if you want to. >> >> I also fixed a bug in PPG. >> >> See the file README.txt for more details. >> > > What's the license of the code? > Following the spirit of dcraw, that would be "All ... code remains free for all uses.". Of course, the file dcraw.c remains subject the additional restrictions indicated in its header. The goal is of course to have it incorporated fully or in part in any project where it could be useful; dcraw of course, but also ufraw and, if you are interested, in libopenraw. I quickly tested it today on a 64bit processor (a CORE 2 DUO) and I found a few problems: - If the first implementation of the PIXEL related macro is used then the local variable rowsize is incorrectly (re-)computed in ppg_phase1 and ppg_phase23. The value computed in ppg_interpolate_new using INIT_ROWSIZE is correct but currently unused. The solution is to pass rowsize as argument of ppg_phase1 and ppg_phase23. - the use of the 32bit types 'int' and 'unsigned' for the variables used to compute array indexes (e.g. rowsize, width, row, ...) prevents gcc to parallelize some loops. For best performances those variables should be set to a type such as size_t or long that matches the size of the pointer types. I will fix that this week-end. > Hub > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > ufraw-devel mailing list > ufr...@li... > https://lists.sourceforge.net/lists/listinfo/ufraw-devel > > |