#349 ufraw-gimp - compilation crash (FC19 + git_gimp + git_gegl/babl)

closed-fixed
nobody
None
5
2014-08-10
2013-07-05
Jaroslav Tvrdy
No

Hello, compilation ufraw-gimp (today CVS) crash.
FC19 x86_64 git:gimp,gelel,babl (today fresh 05.07.2013)

# output:

In file included from /usr/include/exiv2/metadatum.hpp:39:0,
from /usr/include/exiv2/exif.hpp:34,
from /usr/include/exiv2/image.hpp:41,
from ufraw_exiv2.cc:18:
/usr/include/exiv2/value.hpp:984:25: note: attribute for ‘struct Exiv2::DateValue::Date’ must follow the ‘struct’ keyword
EXIV2API struct Date
^
CC iccjpeg.o
CC ufraw_preview.o
ufraw_preview.c: In function ‘colormgmt_fill_interface’:
ufraw_preview.c:4772:42: warning: unused parameter ‘plugin’ [-Wunused-parameter]
int plugin)
^
CC ufraw_saver.o
CC ufraw_delete.o
CC ufraw_chooser.o
CC ufraw_icons.o
CC curveeditor_widget.o
CC ufraw_lens_ui.o
AR libufraw.a
CC ufraw-batch.o
GEN ufraw-batch
CXX dcraw-dcraw.o
CXXLD dcraw
CC nikon_curve-nikon_curve.o
GEN nikon-curve
CC ufraw_gimp-ufraw-gimp.o
ufraw-gimp.c: In function ‘ufraw_save_gimp_image’:
ufraw-gimp.c:363:52: error: ‘GIMP_PRECISION_U8’ undeclared (first use in this function)
depth == 3 ? GIMP_PRECISION_U8 :
^
ufraw-gimp.c:363:52: note: each undeclared identifier is reported only once for each function it appears in
ufraw-gimp.c:364:39: error: ‘GIMP_PRECISION_U16’ undeclared (first use in this function)
GIMP_PRECISION_U16);
^
ufraw-gimp.c:435:13: warning: ‘gimp_image_parasite_attach’ is deprecated (declared at /usr/local/include/gimp-2.0/libgimp/gimpimage.h:94): Use 'gimp_image_attach_parasite' instead [-Wdeprecated-declarations]
gimp_image_parasite_attach(uf->gimpImage, exif_parasite);
^
ufraw-gimp.c:449:13: warning: ‘gimp_image_parasite_attach’ is deprecated (declared at /usr/local/include/gimp-2.0/libgimp/gimpimage.h:94): Use 'gimp_image_attach_parasite' instead [-Wdeprecated-declarations]
gimp_image_parasite_attach(uf->gimpImage, icc_parasite);
^
make[2]: [ufraw_gimp-ufraw-gimp.o] Error 1
make[2]: Leaving directory /home/jarda/install/Gimp/unstable/ufraw' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory/home/jarda/install/Gimp/unstable/ufraw'
make:
[all] Error 2

Discussion

  • Jaroslav Tvrdy
    Jaroslav Tvrdy
    2013-07-05

    I am repair eprecated name: gimp_image_attach_parasite in ufraw-gimp.c
    and messages:

    In file included from /usr/include/exiv2/metadatum.hpp:39:0,
    from /usr/include/exiv2/exif.hpp:34,
    from /usr/include/exiv2/image.hpp:41,
    from ufraw_exiv2.cc:18:
    /usr/include/exiv2/value.hpp:984:25: note: attribute for ‘struct Exiv2::DateValue::Date’ must follow the ‘struct’ keyword
    EXIV2API struct Date
    ^
    CC iccjpeg.o
    CC ufraw_preview.o
    ufraw_preview.c: In function ‘colormgmt_fill_interface’:
    ufraw_preview.c:4772:42: warning: unused parameter ‘plugin’ [-Wunused-parameter]
    int plugin)
    ^
    CC ufraw_saver.o
    CC ufraw_delete.o
    CC ufraw_chooser.o
    CC ufraw_icons.o
    CC curveeditor_widget.o
    CC ufraw_lens_ui.o
    AR libufraw.a
    CC ufraw-batch.o
    GEN ufraw-batch
    CXX dcraw-dcraw.o
    CXXLD dcraw
    CC nikon_curve-nikon_curve.o
    GEN nikon-curve
    CC ufraw_gimp-ufraw-gimp.o
    ufraw-gimp.c: In function ‘ufraw_save_gimp_image’:
    ufraw-gimp.c:363:52: error: ‘GIMP_PRECISION_U8’ undeclared (first use in this function)
    depth == 3 ? GIMP_PRECISION_U8 :
    ^
    ufraw-gimp.c:363:52: note: each undeclared identifier is reported only once for each function it appears in
    ufraw-gimp.c:364:39: error: ‘GIMP_PRECISION_U16’ undeclared (first use in this function)
    GIMP_PRECISION_U16);
    ^
    make[2]: [ufraw_gimp-ufraw-gimp.o] Error 1
    make[2]: Leaving directory /home/jarda/install/Gimp/unstable/ufraw' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory/home/jarda/install/Gimp/unstable/ufraw'
    make:
    [all] Error 2

     
  • I have changed the UFRaw cvs code to match the current GIMP development (git) code, but I have not tested it. Please test and report back if it works for you.

    Regards,
    Niels Kristian

     
  • Jaroslav Tvrdy
    Jaroslav Tvrdy
    2013-07-06

    Hello, compilation work fine, thanks.

    Unfortunately not work, when i am open .nef (nikon RAW) or raw from nikon 1, canon cr2, gimp open only small preview, (cr2 open dialog to import pages and open none) ... but this not long time problem between ufraw-gimp and gimp, and transfer to gimp from ufraw don't work too, because ufraw send definition file to /tmp/, not image.

    https://sourceforge.net/p/ufraw/bugs/346/

     
    • Status: open --> closed-fixed