[TWiki-Dev] [SVN] r8770 - twiki/branches/DEVELOP/lib/TWiki

[<Pet...@nt...>]

Author: PeterThoeny
Date: 2006-02-11 21:41:12 -0800 (Sat, 11 Feb 2006)
New Revision: 8770

Modified:
   twiki/branches/DEVELOP/lib/TWiki/Form.pm
Log:
Item1619: Label form field content destroyed fix (do not render hidden form field value of label field)

Modified: twiki/branches/DEVELOP/lib/TWiki/Form.pm
===================================================================
--- twiki/branches/DEVELOP/lib/TWiki/Form.pm	2006-02-11 02:32:53 UTC (rev 8769)
+++ twiki/branches/DEVELOP/lib/TWiki/Form.pm	2006-02-12 05:41:12 UTC (rev 8770)
@@ -439,16 +439,12 @@
                                  -value => $value );
 
     } elsif( $type eq 'label' ) {
-        # Interesting question: if something is defined as "label",
-        # could it be changed by applications or is the value
-        # necessarily identical to what is in the form? If we can
-        # take it from the text, we must be sure it cannot be
-        # changed through the URL?
+        # Changed labels through the URL is a feature for TWiki applications
         my $renderedValue = $session->{renderer}->getRenderedVersion
           ( $session->handleCommonTags( $value, $web, $topic ));
         $value = CGI::hidden( -name => $name,
                               -class => 'twikiEditFormLabelField',
-                              -value => $renderedValue );
+                              -value => $value );
         $value .= CGI::div( { class => 'twikiEditFormLabelField' },
                             $renderedValue );