#34 Saved images on should be stored in My Documents/My Pictures

v0.9.18
open
5
2012-10-03
2004-10-30
No

Saved images on should be stored in 'My Documents/My
Pictures' on
Windows. The actual directory name is different for
each user,
and is stored in the registry at:

HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\ User Shell Folders\My Pictures
(It also varies with the language Windows is in, e.g.
'Mine dokumenter/Mine bilder' on the Norwegian
version of Windows,
but the registry key above will always contain the
correct name/address.)

Discussion

  • Logged In: YES
    user_id=132410
    Originator: NO

    John - this has been addressed, correct? If so, I'll mark this as Closed/Fixed. Thanks!

     
  • Logged In: YES
    user_id=143340
    Originator: NO

    This hasn't been addressed, no. The current "savedir" arrangement (Windows and Linux) assumes this structure on the disc (or something like it):

    savedir/tuxpaint.cfg (Windows-only)
    savedir/current_id.txt
    savedir/lockfile.dat (Unix-only)
    savedir/saved/ <-- the pictures are here
    savedir/saved/.thumbs/

    which isn't suitable for putting into "My Documents/My Pictures". If the "/saved/" directory, where the pictures actually live, could be moved independently of the others, that might work.

    There are other consequences on Windows: users would expect to be able to double-click on a picture and open it in Tux Paint, which doesn't fit with the way Tux Paint works at the moment,

    cheers,
    John.

     
  • Logged In: YES
    user_id=132410
    Originator: NO

    Based on John's comments, sounds like Bug #1057337 blocks this.

     
  • Logged In: YES
    user_id=132410
    Originator: NO

    Bug #1057337 is fixed (added a "--datadir" option, which covers stamps, brushes, starters and fonts). For this bug, though, a kind of "--metasavedir" might be useful, for lockfile, current ID, thumbnails, and perhaps image metadata (which Starter is attached, what color the background is, etc.). (Allowing these to be separated from the plain PNGs).

    John, what do you think?

     
  • Logged In: YES
    user_id=143340
    Originator: NO

    I don't know how people use the "My Pictures" directory. Does it normally have 10,000 jpg images from their camera in it? Mine is empty.

    Would the pictures go into a 'TuxPaint' sub-directory? We'd need to lose the 'saved' path component and the 'current_id.txt' file. I don't think thumbnails in a sub-directory is a problem though.

    What about the 'Where have all my pictures gone?' moment? Could we support the old and the new locations, but only save new pictures into the new location?

    Or maybe Tux Paint could detect files in the old location and offer to move them? (My experiences suggest that the installer is the wrong place to do this kind of thing).

    I'm busy at the moment, but looking at the printing issue in spare moments.

     
  • Logged In: YES
    user_id=132410
    Originator: NO

    John wrote:

    I don't know how people use the "My Pictures" directory. Does it normally
    have 10,000 jpg images from their camera in it? Mine is empty.

    Good question. I don't use My Documents or My Pictures when I do use Windows, so I have no idea what the 'typical' user expects.

    Would the pictures go into a 'TuxPaint' sub-directory? We'd need to lose
    the 'saved' path component and the 'current_id.txt' file. I don't think
    thumbnails in a sub-directory is a problem though.

    Where do you suggest "current_id.txt" go? The metasavedir location I suggested?
    I see what you mean about "saved" being appended to the path.

    What about the 'Where have all my pictures gone?' moment? Could we support
    the old and the new locations, but only save new pictures into the new
    location?

    This would have been an issue from the beginning; it's kind of outside the scope of these issues, and is its own problem. :)

    Thanks.

     
  • Logged In: YES
    user_id=143340
    Originator: NO

    Where do you suggest "current_id.txt" go? The metasavedir location I suggested?

    I guess so, yes.

    What about the 'Where have all my pictures gone?' moment? Could we support
    the old and the new locations, but only save new pictures into the new
    location?

    This would have been an issue from the beginning; it's kind of outside the
    scope of these issues, and is its own problem. :)

    Yes, sorry about that. Bit of a hurried brain-dump :-)

    Currently, the pictures are stored in a far from ideal location for people who want to play with the image files (or share them), so it seems worth the effort to move them and slightly re-structure the directory layout.

    Cheers!