TrouSerS / Bugs / #169 [build] missing dependency

#169 [build] missing dependency

Milestone: Bug

Status: closed-invalid

Owner: Hon Ching(Vicky) Lo

Labels: None

Priority: 5

Updated: 2014-10-30

Created: 2013-07-20

Creator: Alon Bar-Lev

Private: No

diff --git a/lib/Makefile.am b/lib/Makefile.am
index cef6a2f..d7092a7 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -80,4 +80,4 @@ endif
# Unseal library - for addition to existing apps, counter part of seal cmd
libtpm_unseal_la_SOURCES = tpm_unseal.c
libtpm_unseal_la_LDFLAGS = -shared -version-info 1:0:0
-libtpm_unseal_la_LIBADD = -ltspi libtpm_tspi.la
+libtpm_unseal_la_LIBADD = -ltspi libtpm_tspi.la -lcrypto

Discussion

Alon Bar-Lev - 2013-07-20

I also think the order should be internal libraries first then external...

libtpm_unseal_la_LIBADD = libtpm_tspi.la -ltspi -lcrypto

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alon Bar-Lev - 2013-07-20

Please consider to review[1]

Using -Werror within autoconf or forcing bitness -m64 is something that should be avoided and provided with by explicit requires (--enable-strict) or by external CFLAGS.

Thanks!

[1] http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-crypt/tpm-tools/tpm-tools-1.3.8.ebuild?revision=1.1&view=markup

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Hon Ching(Vicky) Lo - 2014-10-30

status: open --> closed-invalid

assigned_to: Hon Ching(Vicky) Lo
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

[build] missing dependency

Group

Searches

Help

#169 [build] missing dependency

Discussion