Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#79 don't fire AA guns on start of movement if already firing on end of movement

Unstable (example)
closed-accepted
Chris Duncan
None
5
2014-01-13
2013-09-25
David Landry
No

There is a block of code that checks if we are moving from a territory with an enemy AA, and provided we didn't fight a battle there, causes it to fire. This is to prevent the player from moving one step at a time over AA guns and avoiding fire altogether.

But, this doesn't really make sense if you have ForceAAattacksForLastStepOfFlyOver enabled, since then it fires when you move there, and again when you move away.

This was also causing issues with 1914 where a unit can begin in a territory with an enemy AA (really sea mines), but it shouldn't fire when moving out.

1 Attachments

Discussion

  • Chris Duncan
    Chris Duncan
    2014-01-13

    • status: open --> closed-accepted
    • assigned_to: Chris Duncan
     
  • Chris Duncan
    Chris Duncan
    2014-01-13

    accepted and committed

    i am still trying to think of if there is a way this change could be abused by a player?