#41 PlacementSaveBug + Minor Things

closed-accepted
nobody
None
5
2012-03-12
2011-07-16
frigoref
No

PlacementSaveBug: reason was that the palcement move contained its delegate which is not serilizable
solved like combat/noncombat move: references to delegate are done by DelegateFinder

MoveDelegateHierarchy: IAbstractMoveDelegate and first-level.subinterfaces didn't derive from IDelegate, but all the classes that implement these interfaces.
solve by letting IAbstractMoveDelegate extend IDelegate (in addition to IRemote)

Cleaning:
warnings for all classes TOUCHED by the prior changes were reviewed and solved like:
- SuppressWarnings("serial") for serializable objects
- iterator type casting (iterator was specified before)
- missing javadoc tags in comments
- uncommenting never used private methods
- reverse iterator was used for traversing a list in reversed order (MoveDelegate.java)

Discussion

  • Chris Duncan
    Chris Duncan
    2011-07-16

    Looks good, and seems to have solved the problem. What are the new description classes exactly?

     
  • Chris Duncan
    Chris Duncan
    2011-07-16

    • status: open --> pending-accepted
     
  • Chris Duncan
    Chris Duncan
    2012-03-12

    • status: pending-accepted --> closed-accepted