Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo
This patch fixes/is supposed to fix the bug of the moving validator for land units.
A 2length route for land untis that crosses water was prefered over the land route of length 3 - even though the route crossing water was not a valid route.
One problem seems to remain: if you try the same with a combined force of land units and air units it will show that the move is not possible.
The question is what should it do?
a) drop the land units
b) drop the air units
c) keep both and create two routes (could be very hard to implement)
actually the get best route code is a load of crap,
simply using matches to determine the makeup of the units being moved, then picking the best route for that makeup
if there are air, try to get something not over an aa gun
if there is water, don't do land
if there is land, don't do water
simple to do, i'll get it done.
Alright, i completely rewrote get best route to be much much better. This patch is not needed anymore.
Frig, could you double check and bug test my commit for the new getbestroute, please?