Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#14 End Game Scenarios bug

closed-fixed
Michael Flynn
None
5
2010-04-12
2010-03-28
Michael Flynn
No

For some reason the % for the # of Paths columns is incorrect. It seems to be a multiple of what it should be. It was 2x the correct value, but when I ran the "Recalculate Paths To Victory AND delete previous calculations" it changed to be 3x the correct value.

Discussion

  • Michael Flynn
    Michael Flynn
    2010-03-28

    The SQL to clear out the possible_scores table was bad. This was not showing up because the mysql_query didn't have a 'or die' after it or any error checking. Adding error checking and debug code showed the problem query.

    "DELETE from `possible_scores` p where type ='".$type."' and p.`type`='path_to_victory'" where $type = path_to_victory

    Putting the SQL into phpMyAdmin threw an error. I changed the statement to be:
    "DELETE from `possible_scores` where type ='".$type."'"
    The and part of the query seemed redundant so I removed it along with the table alias. Calculations now seem to be correct.

     
  • Michael Flynn
    Michael Flynn
    2010-03-28

    • status: open --> pending-fixed
     
  • This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
    • status: pending-fixed --> closed-fixed
     
  • John Holder
    John Holder
    2010-04-12

    And Michael's fix is in 1.5.3.5.