Re: [torrus-users] PATCH: torrus-1.0.9 - always install .sample files for baseline configuration
Brought to you by:
ssinyagin
From: Stanislav S. <ssi...@ya...> - 2010-10-28 19:55:16
|
hi Corey, as a contra-reason for these patches, torrus-siteconfig.pl and site-global.xml had their latest modification 6 years ago, you can see that in http://sourceforge.net/apps/trac/torrus/browser/trunk/src/configs that's simply because they are not supposed to change, and all new features are placed elsewhere. ----- Original Message ---- > From: Corey Smith <cs...@bo...> > To: "tor...@li..." <tor...@li...>; >Stanislav Sinyagin <ssi...@ya...> > Sent: Thu, October 28, 2010 9:26:36 PM > Subject: [torrus-users] PATCH: torrus-1.0.9 - always install .sample files for >baseline configuration > > Stanislav, > > For your consideration. > > In FreeBSD ports it is common for an example of the current baseline > configuration files to be installed with the .sample suffix. Currently > Torrus will install baseline configuration files in siteconfdir and > sitexmldir only if they don't exist. The attached patches add the > behavior of always installing the current baseline configuration files > as the filename.sample. > > The reasoning is thus: A new feature is added and a corresponding > configuration change is made in one of these files. The user's version > of these files should never be overwritten and never will be by the > Torrus installer. Always installing the .sample version provides the > user with an easy way to see an example of this configuration change. > For example: diff -u site-global.xml site-global.xml.sample > > The FreeBSD port of Torrus has had a version of these patches for 5 > years. > > -Corey Smith > |