This is really peculiar one - I have my TOra stayed opened for more than several days at a time running queries and browsing DB objects and it never hangs. So I can't really reproduce what you are saying. Could you please tell me what version of QT3 Free you were using that caused the problem that you describe (and I mean released by QT3 team as stable ;)?
 
Also I don't have an immediate thought about your problem with status line as this part of TOra was not really changed from the time when we started to port it to QT3 Free for Windows (I mean that toThread::MainThread is always 0). I only fixed the wait method that was at that time unimplemented in QT3 Free port for Windows.
 
Alexey
-----Original Message-----
From: Dandrea Francesco [mailto:francesco.dandrea@telecomitalia.it]
Sent: Monday, January 30, 2006 10:06 AM
To: Alexey Danilchenko; tora-develop@lists.sourceforge.net
Subject: R: [Tora-develop] A question

 
The problem is in tonoblockingquery.cpp.
At line 318 thre is a lock.
This lock should be released when the destructor of toLocker is invoked, and since it's allocated on the stack this means at the end of the method. The problem is that the lock is never released and tora hangs. I traced all to tothread.cpp, the method toThread::start at line 342. The thread is started, but the Thread.StartSemaphore.down() never returns (if I remember correctly... I'm not sure...). I remember that I concluded that wait(QMutex *mutex, unsigned long time = ULONG_MAX) don't return. Then I saw your comment, and then I realised that the method now it's implemented (but looking at the source in a different way, or adding some condition at least...). I removed the ifdefs and it worked...

To reproduce the bug you have only to execute query... On my PC in 5/10 minutes Tora hangs...

PS: since you implemented the threading on Windows, I have a question for you. There is a bug in tothread.cpp, toThread::MainThread is always 0, it's never initialized and so bool toThread::mainThread(void) returns always false. The effect is that the status bar is never populated on Windows (look to utils.cpp, void toStatusMessage(const QString &str, bool save, bool log)) Now, if I fix this bug I can see the errors in the status bar for example in PL/SQL debugger... But when I execute invalid SQL in SQL Worksheet (try select from dual for example), the status bar is empty... toThread::mainThread() is always false. Do you have any idea? Maybe signlas are dispatched in a different way in Qt/Free?
Ciao


________________________________

Da: Alexey Danilchenko [mailto:a.danilchenko@searchspace.com]
Inviato: luned́ 30 gennaio 2006 10.29
A: Dandrea Francesco; tora-develop@lists.sourceforge.net
Oggetto: RE: [Tora-develop] A question


Are you sure this fix was needed? Although the wait method was not working properly in previous QT3/Free Windows port - I implemented it in TOra albeit in different class (see toWaitCondition.wait(QMutex *mutex, unsigned long time = ULONG_MAX) for WIN32 definition in tothread.h/tothread.cpp). Actually I asked QT3 chaps to incorporate this very method in QT3 itself so they have pretty much the same implementation as we do. And because ours implemented subclass of QWaitCondition - it should work regardless whether they have a proper implementation of wait() or not in QT3. Also I personally didn't experienced TOra hanging since we ported it on Windows (crashing - yes but not hanging) and if you did - could you please point what circumstances (i.e. which part of the TOra was used at that moment, what you were doing etc.). Otherwise, I don't think this needs to be there that urgently (not until the QT3 Free guys will post another stable binary) - this is imho of course.


Alexey



-----Original Message-----
From: Dandrea Francesco [mailto:francesco.dandrea@telecomitalia.it]
Sent: Monday, January 30, 2006 8:25 AM
To: Alexey Danilchenko; tora-develop@lists.sourceforge.net
Subject: R: [Tora-develop] A question



I think that it's important to keep in mind the audience.
Thera are 2 possible audience:
1) Developers: If someone is able to compile Tora on Windows, I don't think that he has problem compiing Qt/Free
2) Users: I think we should provide a binary package to them...

So I think that we ca safely move to Qt/Free 3.3.4-5 as requirement...

In every case the change that requires Qt/Free 3.3.4-5 is to ththread.{cpp,h}.
In tothread.h you can read this comment:
// this method is not implemented in QT Free port
bool wait( QMutex *mutex, unsigned long time = ULONG_MAX );

Now, in Qt/Free 3.3.4-5 this method IS implemented, so we can remove this workround. And Tora doesn't hang so much...
Ciao

>-----Messaggio originale-----
>Da: tora-develop-admin@lists.sourceforge.net
>[mailto:tora-develop-admin@lists.sourceforge.net] Per conto di
>Alexey Danilchenko
>Inviato: venerd́ 27 gennaio 2006 18.27
>A: tora-develop@lists.sourceforge.net
>Oggetto: RE: [Tora-develop] A question
>
>We did this before they have following inbeen producing binary
>builds. Their site used to describe how to build QT from
>scratch and it was relatively easy. Anyway, someone could
>build one and we can tar it up and upload to TOra on SF.
>
>Alexey
>
>> -----Original Message-----
>> From: tora-develop-admin@lists.sourceforge.net
>> [mailto:tora-develop-admin@lists.sourceforge.net]On Behalf Of
>> Neulinger, Nathan
>> Sent: Friday, January 27, 2006 5:21 PM
>> To: Dandrea Francesco; tora-develop@lists.sourceforge.net
>> Subject: RE: [Tora-develop] A question
>>
>>
>> Is there any way to special case them on the version without it being
>> really ugly?
>>
>>
>> ------------------------------------------------------------
>> Nathan Neulinger EMail: nneul@umr.edu
>> University of Missouri - Rolla Phone: (573) 341-6679
>> UMR Information Technology Fax: (573) 341-4216
>>
>>
>> > -----Original Message-----
>> > From: tora-develop-admin@lists.sourceforge.net
>> > [mailto:tora-develop-admin@lists.sourceforge.net] On Behalf
>> > Of Dandrea Francesco
>> > Sent: Friday, January 27, 2006 9:47 AM
>> > To: tora-develop@lists.sourceforge.net
>> > Subject: [Tora-develop] A question
>> >
>> >
>> > Hi all, I have here sitting on my Hard Disk a couple of
>patches that
>> > makes Tora a bit better on Windows (it solves some locking
>> problem and
>> > the status bar works more or less).
>> > One of the patch requires a version of QT/Free after
>Qt/Free 3.3.4-3
>> > (I'm using a snapshot of the 6th of January, but Qt/Free
>> > 3.3.4-5 should
>> > be ok). The problem is that the Qt/Free project doesn't
>> > release anymore
>> > a binary... The last one was 3.3.4-3. The only way is to
>> > compile Qt/Free
>> > by hand (which is not so difficult to be fair...) The patches only
>> > affect code on Windows.
>> > What do you think?
>> >
>> >
>> >
>--------------------------------------------------------------------
>> > CONFIDENTIALITY NOTICE
>> > This message and its attachments are addressed solely to
>the persons
>> > above and may contain confidential information. If you
>have received
>> > the message in error, be informed that any use of the
>content hereof
>> > is prohibited. Please return it immediately to the sender
>and delete
>> > the message. Should you have any questions, please contact us by
>> > replying to webmaster@telecomitalia.it
>> > .
>> > Thank you
>> > www.telecomitalia.it
>> >
>> >
>--------------------------------------------------------------------
>> >
>>
>>
>> -------------------------------------------------------
>> This SF.net email is sponsored by: Splunk Inc. Do you grep
>> through log files
>> for problems? Stop! Download the new AJAX search engine that makes
>> searching your log files as easy as surfing the web.
>> DOWNLOAD SPLUNK!
>> http://sel.as-us.falkag.net/sel?cmd=k&kid3432&bid#0486&dat1642
>> _______________________________________________
>> Tora-develop mailing list
>> Tora-develop@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/tora-develop
>>
>
>
>-------------------------------------------------------
>This SF.net email is sponsored by: Splunk Inc. Do you grep
>through log files
>for problems? Stop! Download the new AJAX search engine that makes
>searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
>http://sel.as-us.falkag.net/sel?cmd=k&kid3432&bid#0486&dat1642
>_______________________________________________
>Tora-develop mailing list
>Tora-develop@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/tora-develop
>

--------------------------------------------------------------------
CONFIDENTIALITY NOTICE
This message and its attachments are addressed solely to the persons
above and may contain confidential information. If you have received
the message in error, be informed that any use of the content hereof
is prohibited. Please return it immediately to the sender and delete
the message. Should you have any questions, please contact us by
replying to webmaster@telecomitalia.it .
Thank you
www.telecomitalia.it
--------------------------------------------------------------------

--------------------------------------------------------------------
CONFIDENTIALITY NOTICE
This message and its attachments are addressed solely to the persons
above and may contain confidential information. If you have received
the message in error, be informed that any use of the content hereof
is prohibited. Please return it immediately to the sender and delete
the message. Should you have any questions, please contact us by
replying to
webmaster@telecomitalia.it.
        Thank you
                                       
www.telecomitalia.it
--------------------------------------------------------------------