Ok, this is only to confirm that:
1) the patch compiles just right
2) the behaviour is the exposed one (when the 9.0 version of the query is not found, it uses the 8.0)

Ciao

>-----Messaggio originale-----
>Da: Mike Fleetwood [mailto:mike@rockover.demon.co.uk]
>Inviato: giovedý 21 luglio 2005 1.58
>A: tora-develop
>Cc: Dandrea Francesco
>Oggetto: Re: [Tora-develop] Updated Oracle SQL for execution
>tuning charts
>
>Hi Dandrea,
>
>1) Yes thats right. Update the queries for Oracle 8.0 and 9.0. Also
>leave the queries for Oracle 7.3 the same because they suggest
>that Oracle
>7.3 doesn't provide the "Hard parse" statistic, and I don't
>have Oracle
>7.3 to test against.
>
>2) I think that you are asking whether you have replaced the
>correct old
>queries with my new ones, as I only provided the TOra query
>names and not
>the old query to be replaced. It looks correct to me, but this is my
>first look at TOra's source code.
>
>3) From using TOra, but not even looking at the code to confirm, TOra
>seems to use a query marked for an earlier version of the
>database if it
>doesn't have a query for the exact version of the database it is
>currently connected to. If this is the case then I suggest
>the following
>change instead:
> * Update SQLChartsExecution, for Ora 8.0
> * Remove SQLChartsExecution9, for Ora 9.0
> * Update SQLChartsExecutionPie, for Ora 8.0
> * Remove SQLChartsExecutionPie9, for Ora 9.0
>To this end I have attached a patch which makes this
>alternative change.
>Note that I have only written the code, I can't compile or test the
>code because ./configure complains it can't compile and run a
>simple OCI
>app.
>
>Thanks,
>Mike
>--
> __ __ _ _ ___ ____ _ ___ ___ _ ___ ___ _
>| \/ (_| | _ / _ \ | ___| | / _ \/ _ \| |_ _ _ _/ \/ \ _| |
>| |\/| | | |/ | ___| | _| | |_| __| ___| __| \/ \/| O | O / _ |
>|_| |_|_|_|\_\\___| |_| |____\___|\___||____\_/^\_/\___/\___/\___|
>
>
>On Wed, 20 Jul 2005, Dandrea Francesco wrote:
>
>> In attachement there is the patch (against 1.3.18) for the changes.
>> Note:
>> 1) I changed the version of the query for Oracle 8 and
>Oracle 9. The query is the old one for Oracle 7. Is this right?
>> 2) I don't know the argument, and I don't know if the
>proposed one is the "right" query.
>>
>> Ciao
>>> -----Messaggio originale-----
>>> Da: tora-develop-admin@lists.sourceforge.net
>>> [mailto:tora-develop-admin@lists.sourceforge.net] Per conto di
>>> Mike Fleetwood
>>> Inviato: lunedý 18 luglio 2005 22.24
>>> A: tora-develop
>>> Oggetto: [Tora-develop] Updated Oracle SQL for execution
>tuning charts
>>>
>>> Hi All,
>>>
>>> I have been using TOra (from 1.2.4 to 1.3.18) with Oracle 9.2 and
>>> noticed that the Execution graph and Execution Total pie chart are
>>> wrong. The queries behind these 2 charts select data from v$sysstat
>>> based on statistic#. However Oracle state that statistic#
>may change
>>> between versions, and has changed in Oracle 9.2, but that name
>>> is fixed.
>>>
>>> Quote from the Oracle9i Database Reference Release 2
>>> http://www.cs.umb.edu/cs634/ora9idocs/server.920/a96536/ch3215.
>>> htm#1127407
>>>
>>> Column Datatype Description
>>> ---------- ------------
>>> --------------------------------------------
>>> STATISTIC# NUMBER Statistic number
>>> Note: Statistics numbers are not
>>> guaranteed
>>> to remain constant from one release to
>>> another. Therefore, you should
>>> rely on the
>>> statistics name rather than its
>number in
>>> your applications.
>>> NAME VARCHAR2(64) Statistic name
>>>
>>> So I have re-written the 2 queries using the name instead of
>>> statistic#.
>>>
>>> toTuning:Charts:6LNExecution
>>> ----------------------------
>>> SELECT SYSDATE,
>>> SUM(DECODE(name,'execute count',value,0)) "Execute",
>>> SUM(DECODE(name,'parse count (hard)',value,0)) "Hard parse",
>>> SUM(DECODE(name,'parse count (total)',value,0)) "Parse",
>>> SUM(DECODE(name,'user calls',value,0)) "Calls",
>>> SUM(DECODE(name,'user commits',value,0)) "Commit",
>>> SUM(DECODE(name,'user rollbacks',value,0)) "Rollbacks"
>>> FROM v$sysstat
>>> WHERE name IN ('execute count',
>>> 'parse count (hard)',
>>> 'parse count (total)',
>>> 'user calls',
>>> 'user commits',
>>> 'user rollbacks')
>>>
>>> toTuning:Charts:8PNExecution Total
>>> ----------------------------------
>>> SELECT value,
>>> DECODE(name,'execute count', 'Execute',
>>> 'parse count (hard)', 'Hard parse',
>>> 'parse count (total)','Parse',
>>> 'user calls', 'Calls',
>>> 'user commits', 'Commit',
>>> 'user rollbacks', 'Rollbacks')
>>> FROM v$sysstat
>>> WHERE name IN ('execute count',
>>> 'parse count (hard)',
>>> 'parse count (total)',
>>> 'user calls',
>>> 'user commits',
>>> 'user rollbacks')
>>> ORDER BY name
>>>
>>> I have successfully tested both queries against Oracle 8.0,
>8.1 and 9.2
>>> using sqlplus. I have put the queries into TOra via the
>GUI and tested
>>> them against Oracle 9.2 and got the correct results. If you could
>>> include these queries in TOra that would be great.
>>>
>>> Many thanks,
>>> Mike
>
--------------------------------------------------------------------
CONFIDENTIALITY NOTICE
This message and its attachments are addressed solely to the persons
above and may contain confidential information. If you have received
the message in error, be informed that any use of the content hereof
is prohibited. Please return it immediately to the sender and delete
the message. Should you have any questions, please contact us by
replying to
webmaster@telecomitalia.it.
        Thank you
                                       
www.telecomitalia.it
--------------------------------------------------------------------