TOra segfault bug fix

Help
2004-10-24
2012-12-13
  • Raj Thukral
    Raj Thukral
    2004-10-24

    I *think* I've found the fix to the TOra segfaulting bug, but I need more testing.  Since this bug is so frikkin' random, I haven't been able to get TOra to crash since I made this change, and the gdb backtrace consistently pointed here, so I think I've fixed it, but I'd like confirmation and also perhaps some testing to see if something else broke somewhere :)
    The fix is simple.  modify line 144 of tonoblockquery.cpp to:

    if (!Parent.Error&&!Parent.Query->eof())

    (the original was if (!Parent.Query->eof()) )

    cheers!
    --Raj

     
    • Raj Thukral
      Raj Thukral
      2004-10-24

      Thats on version 1.3.14.1 btw.

       
    • G B
      G B
      2004-11-02

      It used to crash quite often for me, almost every time I mis-typed a table name in a query, or clicked on the "Schema Browser".  I applied your patch, along with ibre5041's patch.  It has not crashed since then, and I haven't seen any odd behavior.  Than you, really appreciate it.

      -- george