Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#871 TOra3: Can't change syntax highlighting colors

None
closed-fixed
Ivan Brezina
5
2013-11-20
2013-09-11
Marian Kyral
No

Hi,
Yesterday I've compiled latest SVN code (TOra 3.0.0 4823svn) and I have a problem with syntax highlight colors.
I'm using a dark schema and the keyword color is too dark for me. See attached screenshot. I wanted to change it in preferences dialog, but it does not work. The code preview newer updates, Apply button does not update colors in editor. Restar of TOra does not help. I also quit TOra and directly updated colors in ~/.config/TOra/TOra.conf, but TOra is ignoring this and uses default colors.
Also the "Syntax highlighting" checkbox in Editor settings/Options has no effect. The text is always highlighted, but checkbox is unchecked.

1 Attachments

Discussion

  • Marian Kyral
    Marian Kyral
    2013-09-11

    It looks like it was not implemented yet:

    toSyntaxAnalyzer::toSyntaxAnalyzer(toHighlightedText *parent)
    : QObject(parent)
    {
    // Colors[Default] = toConfigurationSingle::Instance().syntaxDefault();
    // Colors[Comment] = toConfigurationSingle::Instance().syntaxComment();
    // Colors[Number] = toConfigurationSingle::Instance().syntaxNumber();
    // Colors[Keyword] = toConfigurationSingle::Instance().syntaxKeyword();
    // Colors[String] = toConfigurationSingle::Instance().syntaxString();
    // Colors[DefaultBg] = toConfigurationSingle::Instance().syntaxDefaultBg();
    // Colors[ErrorBg] = toConfigurationSingle::Instance().syntaxErrorBg();
    // Colors[DebugBg] = toConfigurationSingle::Instance().syntaxDebugBg();
    // Colors[CurrentLineMarker] = toConfigurationSingle::Instance().syntaxCurrentLineMarker();
    // Colors[StaticBg] = toConfigurationSingle::Instance().syntaxStaticBg();
    }

    Colors are set, but never used. I've tried to set Colors[Keyword] there, but I don't know a C++ much, so I'm not able to compile it.

     
  • Marian Kyral
    Marian Kyral
    2013-09-12

    I's worse. I'm not able to find out, where is the initial color setting :-( Any help is welcome.

     
  • Ivan Brezina
    Ivan Brezina
    2013-10-21

    This is not implemented yet. At this moment we are moving to Qscintilla editor framework.
    Therefore this must be re-implemented.

     
  • Ivan Brezina
    Ivan Brezina
    2013-10-21

    • status: open --> pending-postponed
    • Group: -->
     
  • Ivan Brezina
    Ivan Brezina
    2013-11-20

    • status: pending-postponed --> closed-fixed
    • assigned_to: Ivan Brezina
     
  • Ivan Brezina
    Ivan Brezina
    2013-11-20

    Done - implemented.

     
  • Marian Kyral
    Marian Kyral
    2013-11-20

    Thanks a lot. It is much better now ;-)

    Just a question. Why there are two columns with line number in preview? And what about the "Syntax highlighting" check box? It is currently inactive.

     
    • Ivan Brezina
      Ivan Brezina
      2013-11-20

      This is still under development. There are two line numbers because 1st one is maintained by qscintilla and it shows absolute line numbers. While the 2nd one is maintained by the "syntax analyzer" and this one shows "statement relative line numbers". You can which the analyzer by clicking on the bottom right corner - "QtSql". Syntax analyzer is responsible for highlighting and also it splits editor's text into statements. At this moment two analyzers are beeing implemented "QtSql" (uses empty line as statement delimiter) and "Oracle" (uses pseudo/quirk parser for PL/SQL).