#324 no limit to -blockcursor width

closed-fixed
18. [text] (26)
7
2012-01-26
2012-01-25
Francois VOGEL
No

The attached patch fixes items 1754043 and 2321450 (which really are dups):

no limit to -blockcursor width:
https://sourceforge.net/tracker/?func=detail&aid=1754043&group_id=12997&atid=112997

Text widget block cursor problem:
https://sourceforge.net/tracker/?func=detail&aid=2321450&group_id=12997&atid=112997

The patch is against core-8-5-branch.

Discussion

  • Francois VOGEL
    Francois VOGEL
    2012-01-25

    Patch claming the width of the block cursor to a maximum when at end of line

     
  • Francois VOGEL
    Francois VOGEL
    2012-01-25

    Test case:

    text .t -blockcursor true
    pack .t
    .t insert end "Some text here\n"
    .t insert end "Further text here"

    Move the insert cursor in the text, and at the end of lines. See it does no longer expand to the right end of the widget.

     
  • Francois VOGEL
    Francois VOGEL
    2012-01-25

    • priority: 5 --> 7
    • assigned_to: hobbs --> nijtmans
     
  • Jan Nijtmans
    Jan Nijtmans
    2012-01-25

    This patch is so trivial, it can go in right away.
    Noting that the -blockcursor option was introduced
    in Tk 8.5, so this patch is for core-8-5-branch
    and trunk only.

    François, would you be interested in commit access
    to Tk''s fossil repositlry, so you can commit those kinds
    of things yourself?

     
  • Francois VOGEL
    Francois VOGEL
    2012-01-25

    Jan, about commit access:
    Basically I feel quite comfortable in having someone reviewing my patches before they go in the production branches. I'm a bit shy of the new responsibility. However after all this is version control, i.e. commits can always be reverted if people are not okay with them.
    So, yes, why not?

     
  • If you're uncertain, just commit to a (new feature development) branch. Branching is enormously easy and cheap now we're using fossil. It also means that if we need to evolve the code before feeding back in, we can do so easily.

    I tend to prefix my feature branch names with my initials, but you can do it any way you want. I suggest not calling it "core..." or "trunk..." or "bug..." :-)

     
  • Don Porter
    Don Porter
    2012-01-25

    • assigned_to: nijtmans --> fvogelnew1
     
  • Francois VOGEL
    Francois VOGEL
    2012-01-25

    The proposed patch is available for review in branch patch-3479498

     
  • Francois VOGEL
    Francois VOGEL
    2012-01-26

    Merged in core-8-5-branch and trunk. Closing now.

     
  • Francois VOGEL
    Francois VOGEL
    2012-01-26

    • status: open --> closed-fixed