Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#316 Submenus not unposting at all expected times after tip #360

closed-fixed
Pat Thoyts
5
2011-05-01
2011-04-28
Schelte Bron
No

After the implementation of tip #360 cascade entries behave inconsistently. Sometimes the submenu is unposted when moving the mouse to another entry, but most of the time the submenu stays up. Pat Thoyts indicated on the Tcl chat that the intended behaviour is that the menu gets unposted. The attached patch accomplishes that.

Discussion

  • Schelte Bron
    Schelte Bron
    2011-04-28

    Patch to produce the correct behaviour

     
    Attachments
    • assigned_to: tmh --> dkf
     
  • Which version of Tk is this a patch against? I ask because it doesn't correspond to the (current) trunk.

     
  • Schelte Bron
    Schelte Bron
    2011-04-30

    The patch is against Tk 8.5.9. Pat already mentioned on the chat that Tk 8.6 has seen a bug fix in this area (#2949774). That one already fixes most of the issues addressed by this patch.

     
  • Pat Thoyts
    Pat Thoyts
    2011-04-30

    What has occurred is that TIP 360 was voted in for 8.6. It was then backported to 8.5 as well for 8.5.9. However there is an additional fix applied to the 8.6 branch that was never backported to 8.5:
    a65a383 [Bug 2949774]: cascade menus should popdown ofter loosing the pointer.

    In discussion with schelte it appears there might be some additional issues with this patch to resolve so a simple backport of this may be insufficient to completely fix things.

     
  • Pat Thoyts
    Pat Thoyts
    2011-04-30

    • assigned_to: dkf --> patthoyts
     
  • Pat Thoyts
    Pat Thoyts
    2011-05-01

    Added the fix from 8.6 to the 8.5 branch plus a modification suggested by sbron to resolve a case where the submenu remained posted when it should not.

     
  • Pat Thoyts
    Pat Thoyts
    2011-05-01

    • status: open --> closed-fixed