#2865 Fix buffer overflow w/ GCC 4.5 and -D_FORTIFY_SOURCE=2

obsolete: 8.6b1.1
closed-fixed
Jan Nijtmans
99. Other (73)
5
2011-01-25
2010-12-06
Jan Nijtmans
No

Same as [Tcl patch #3048354], but it turns out that Tk uses the same pattern as well.

Discussion

  • Jan Nijtmans
    Jan Nijtmans
    2010-12-06

    • assigned_to: nobody --> nijtmans
     
  • Jan Nijtmans
    Jan Nijtmans
    2010-12-06

    proposed fix

     
    Attachments
  • Jan Nijtmans
    Jan Nijtmans
    2010-12-06

    Fixed on HEAD

     
  • Jan Nijtmans
    Jan Nijtmans
    2010-12-06

    • status: open --> open-fixed
     
  • Jan Nijtmans
    Jan Nijtmans
    2010-12-06

    proposed fix (same, but for Tk 8.5)

     
    Attachments
  • Jan Nijtmans
    Jan Nijtmans
    2010-12-06

    proposed fix (same, but for Tk 8.4)

     
    Attachments
  • Joe English
    Joe English
    2011-01-24

    Looks like you missed a spot -- see #3164879 for details.

     
  • Jan Nijtmans
    Jan Nijtmans
    2011-01-25

    Good catch! Thanks!

     
  • Jan Nijtmans
    Jan Nijtmans
    2011-01-25

    • status: open-fixed --> closed-fixed
     
  • Jan Nijtmans
    Jan Nijtmans
    2011-01-25

    Backported the srccpy -> memcpy change to 8.5 and 8.4, not the structure
    change in order to prevent repeating anything like #3164879.