cppcheck results

Developer
Mr. X
2012-02-10
2013-05-20
  • Mr. X
    Mr. X
    2012-02-10

    Checking TinyXml 2.6.2 code with cppcheck (git head) gives this results:

    [H:\cppcheck_1\externals\tinyxml\tinyxml.h:353]: (style) Array index i is used before limits check
    [H:\cppcheck_1\externals\tinyxml\tinyxml.h:1647]: (style) 'TiXmlHandle::operator=' should return 'TiXmlHandle &'
    [H:\cppcheck_1\externals\tinyxml\tinyxml.h:1761]: (style) Technically the member function 'TiXmlPrinter::Indent' can be const.
    [H:\cppcheck_1\externals\tinyxml\tinyxml.h:1768]: (style) Technically the member function 'TiXmlPrinter::LineBreak' can be const.
    [H:\cppcheck_1\externals\tinyxml\tinyxml.h:1777]: (style) Technically the member function 'TiXmlPrinter::CStr' can be const.
    [H:\cppcheck_1\externals\tinyxml\tinyxml.h:1779]: (style) Technically the member function 'TiXmlPrinter::Size' can be const.
    [H:\cppcheck_1\externals\tinyxml\tinyxml.h:1783]: (style) Technically the member function 'TiXmlPrinter::Str' can be const.
    [H:\cppcheck_1\externals\tinyxml\tinyxml.cpp:1238]: (warning) scanf without field width limits can crash with huge input data
    [H:\cppcheck_1\externals\tinyxml\tinyxml.cpp:1245]: (warning) scanf without field width limits can crash with huge input data
    [H:\cppcheck_1\externals\tinyxml\tinyxmlparser.cpp:636]: (error) Possible null pointer dereference: p - otherwise it is redundant to check if p is null at line 634
    [H:\cppcheck_1\externals\tinyxml\tinyxmlparser.cpp:441]: (style) Unused variable: ent
    

    Will they be fixed in next version?