Operator= copy on TiXmlHandle

Developer
2011-09-11
2013-05-20
  • Darcy Rayner
    Darcy Rayner
    2011-09-11

    Hi,  I just built tinyxml with gcc version 4.5.2, using the -Weffc++ flag. The flag reports a lot warnings based on not using initialiser lists in constructors,  (which I'm not so fussed about), but among the noise it  reported that on line 1645 of tinyxml.h :

    TiXmlHandle operator=( const TiXmlHandle& ref )
    

    Was missing the '&'  in the return type. It probably isn't effecting code quality much, but I thought I might just point it out. Was it intentional?