#1 Tasks 130313 & 130314

closed-accepted
5
2006-09-13
2006-09-12
Mahesh DC
No

patch for task 130313 & 130314

Discussion

  • Mahesh DC
    Mahesh DC
    2006-09-12

    task 130313&130314

     
    Attachments
  • Martijn Rutten
    Martijn Rutten
    2006-09-13

    • assigned_to: nobody --> ruttenm
    • status: open --> pending
     
  • Martijn Rutten
    Martijn Rutten
    2006-09-13

    Logged In: YES
    user_id=1563356

    Assigned to ruttenm for review

     
  • Martijn Rutten
    Martijn Rutten
    2006-09-13

    Logged In: YES
    user_id=1563356

    Accepted the patch and included the changes in the
    repository after some minor refactorings:
    - added 'this' keyword to initialization of member
    variables in canvas and paintlistener constructors
    - pruned redundant empty lines
    - subtracted VERTICAL_PADDING from fullHeight already in
    the initialization of fullHeight in all PaintListeners
    - removed VERTICAL_START_POSITION from EventPaintListener,
    replaced this with fullHeight - VERTICAL_PADDING
    - added height argument to SampleFlag.drawFlag to allow
    vertical resizing of notes by dragging the vertical splitter
    - added a black line at the bottom of each trace line
    (makes it easier to see which samples belong to which
    sample line name)
    - extracted a method for drawing grid lines for queues
    - moved magic number '8' to a define MAX_COLORS in the
    TaskPaintListener
    - removed empty constructor in SampleFlag class
    - renamed SampleFlag.drawFlag to sampleFlag.draw
    - renamed local variable imageFlag to sampleFlag to match
    with the class name in various PaintListeners

     
  • Martijn Rutten
    Martijn Rutten
    2006-09-13

    • status: pending --> pending-accepted
     
  • Martijn Rutten
    Martijn Rutten
    2006-09-13

    • status: pending-accepted --> closed-accepted