From: Stephane C. <se...@lo...> - 2010-02-02 14:10:48
|
Le Tue, Feb 02, 2010 at 08:27:37AM -0500, Desilets, Alain écrivait : > Hi Stéphane, Hi Alain, > I really appreciate your help with this, so you'll understand that I > am sorry to be the bearer of bad news ;-). > > I implemented that patch, and now the traces do print the pathes with > / instead of \. Unfortunately, that does not seem to solve the > problem. > > Note that I have cleared my Tiki and Browser caches three times just > to be sure. > > I don't know if it can help, but Firebug reports the following 4 errors: > > --- Firebug reported errors: > Firebug's log limit has been reached. 0 entries not shown. Preferences > setsectionstate is not defined > tiki-index.php()tiki-index.php (line 608) > [Break on this error] $jq("document").ready(function(){ > tiki-index.php (line 608) > $jq is not defined > [Break on this error] $jq("document").ready(function(){ > tiki-index.php (line 521) > $jq is not defined > [Break on this error] $jq(document).ready( function() { > tiki-index.php (line 555) > $jq is not defined > [Break on this error] $jq("document").ready(function(){ > ---- Not related, I can see those too, but they have no impact on the layout, at least here... > And this is what my minify_css() function looks like at the moment. > > -- > private function minify_css( $file ) { > global $tikipath, $tikiroot; > echo "<pre>-- headerlib.minify_css: \$file="; var_dump($file); echo "</pre>\n"; > echo "<pre>-- headerlib.minify_css: \$tikipath="; var_dump($tikipath); echo "</pre>\n"; > echo "<pre>-- headerlib.minify_css: \$tikiroot="; var_dump($tikiroot); echo "</pre>\n"; > > if (strpos($file, $tikiroot) === 0) { > // $currentdir = dirname( $file ); > $currentdir = str_replace('\\', '/',dirname( $file )); > $content = file_get_contents( str_replace( $tikiroot, $tikipath, $file)) ; > echo "<pre>-- headerlib.minify_css: file path contains \$tikirot. \$currentdir="; var_dump($currentdir); echo "</pre>\n"; > // die(); > } else { > if ( $file[0] == '/' ) { > $file = $tikipath.$file; > } > // $currentdir = addslashes(str_replace($tikipath, $tikiroot, dirname(realpath( $file )))); > $currentdir = addslashes(str_replace($tikipath, $tikiroot, str_replace('\\', '/',dirname(realpath( $file ))))); > $content = file_get_contents( $file ); > echo "<pre>-- headerlib.minify_css: file path DOES NOT contains \$tikirot. \$currentdir="; var_dump($currentdir); echo "</pre>\n"; > // die(); > } > -- Ok could you send me the full output (all the echo results, I don't care of the HTML code ! ;) ) of say tiki-index.php, just to see what's happening ? Please put an echo with currentdir and file just before the call to Minify_CSS::minify before the return statement. Thanx for your help in debuging this... A+ -- Stéphane Casset LOGIDÉE sàrl Se faire plaisir d'apprendre 1a, rue Pasteur Tel : +33 388 23 69 77 ca...@lo... F-67540 OSTWALD Fax : +33 388 23 69 77 http://logidee.com |
From: Filipus K. <ch...@gm...> - 2010-01-30 20:24:29
|
Le janvier 30, 2010 02:19:51 PM, Desilets, Alain a écrit : > Hi folks, > > Just upgraded trunk to r24758, and now, the layout of all pages is screwed > up. See attached screenshot. > > Is anyone else seeing this? I do, with thenews. I first noticed it this week, probably between 1 to 3 days ago. This doesn't happen on *all* pages; actually, I only noticed it on the HomePage, the same your screenshot had, with 2 columns, each on its side. The result, at least with thenews, is not quite the same, but it's clearly the same bug, each column taking its side (too much). |
From: luci a. l. d' b. <sf...@gr...> - 2010-01-30 20:32:47
|
i smell the CSS minify is not perfect... try to switch it off on Performance prefs luci On 01/30/2010 09:24 PM, Filipus Klutiero wrote: > Le janvier 30, 2010 02:19:51 PM, Desilets, Alain a écrit : >> Hi folks, >> >> Just upgraded trunk to r24758, and now, the layout of all pages is screwed >> up. See attached screenshot. >> >> Is anyone else seeing this? > I do, with thenews. I first noticed it this week, probably between 1 to 3 days > ago. This doesn't happen on *all* pages; actually, I only noticed it on the > HomePage, the same your screenshot had, with 2 columns, each on its side. The > result, at least with thenews, is not quite the same, but it's clearly the > same bug, each column taking its side (too much). > > ------------------------------------------------------------------------------ > The Planet: dedicated and managed hosting, cloud storage, colocation > Stay online with enterprise data centers and the best network in the business > Choose flexible plans and management services without long-term contracts > Personal 24x7 support from experience hosting pros just a phone call away. > http://p.sf.net/sfu/theplanet-com > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > ---------------------------------------- > Freehosting PIPNI - http://www.pipni.cz/ > |
From: Filipus K. <ch...@gm...> - 2010-01-30 21:38:44
|
It's unrelated to minify. There are also no JavaScript errors. However, trying to validate the HTML shows 25 errors, which could very well explain issues, even if Tiki probably doesn't generate a single validating page. Le janvier 30, 2010 03:32:39 PM, luci aka luciash d' being a écrit : > i smell the CSS minify is not perfect... try to switch it off on > Performance prefs > > luci > > On 01/30/2010 09:24 PM, Filipus Klutiero wrote: > > Le janvier 30, 2010 02:19:51 PM, Desilets, Alain a écrit : > >> Hi folks, > >> > >> Just upgraded trunk to r24758, and now, the layout of all pages is > >> screwed up. See attached screenshot. > >> > >> Is anyone else seeing this? > > > > I do, with thenews. I first noticed it this week, probably between 1 to 3 > > days ago. This doesn't happen on *all* pages; actually, I only noticed it > > on the HomePage, the same your screenshot had, with 2 columns, each on > > its side. The result, at least with thenews, is not quite the same, but > > it's clearly the same bug, each column taking its side (too much). |
From: Jonny B. <jo...@ti...> - 2010-01-30 23:09:19
|
There were some fixes to css minify (thanks LPH and Sept) which fixed all this for me, although there are still quite a few "SUMO induced" XHTML errors in all our pages now (e.g. the role attribute in several divs now) And while we're at it, do we really need four otherwise empty divs containing the central page content? #wrapper > #col1 > #tiki-center > div[role=main] They can't possibly be doing anything that two divs couldn't do, surely? (and that's without feature_layoutshadows enabled) My 2p... jonny On 30 Jan 2010, at 21:38, Filipus Klutiero wrote: > It's unrelated to minify. There are also no JavaScript errors. However, trying > to validate the HTML shows 25 errors, which could very well explain issues, > even if Tiki probably doesn't generate a single validating page. > > Le janvier 30, 2010 03:32:39 PM, luci aka luciash d' being a écrit : >> i smell the CSS minify is not perfect... try to switch it off on >> Performance prefs >> >> luci >> >> On 01/30/2010 09:24 PM, Filipus Klutiero wrote: >>> Le janvier 30, 2010 02:19:51 PM, Desilets, Alain a écrit : >>>> Hi folks, >>>> >>>> Just upgraded trunk to r24758, and now, the layout of all pages is >>>> screwed up. See attached screenshot. >>>> >>>> Is anyone else seeing this? >>> >>> I do, with thenews. I first noticed it this week, probably between 1 to 3 >>> days ago. This doesn't happen on *all* pages; actually, I only noticed it >>> on the HomePage, the same your screenshot had, with 2 columns, each on >>> its side. The result, at least with thenews, is not quite the same, but >>> it's clearly the same bug, each column taking its side (too much). > > ------------------------------------------------------------------------------ > The Planet: dedicated and managed hosting, cloud storage, colocation > Stay online with enterprise data centers and the best network in the business > Choose flexible plans and management services without long-term contracts > Personal 24x7 support from experience hosting pros just a phone call away. > http://p.sf.net/sfu/theplanet-com > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel |
From: luci a. l. d' b. <sf...@gr...> - 2010-01-31 00:40:36
|
hi, div[role=admin] can be probably taken out i am unsure about #tiki-center (we rather need it for some center content tricks) the #wrapper and #col1 is absolutely necessary for *lite to function properly until we drop IE6/7 support luci On 01/31/2010 12:09 AM, Jonny Bradley wrote: > There were some fixes to css minify (thanks LPH and Sept) which fixed all this for me, although there are still quite a few "SUMO induced" XHTML errors in all our pages now (e.g. the role attribute in several divs now) > > And while we're at it, do we really need four otherwise empty divs containing the central page content? > > #wrapper > > #col1 > > #tiki-center > > div[role=main] > > They can't possibly be doing anything that two divs couldn't do, surely? (and that's without feature_layoutshadows enabled) > > My 2p... > > jonny > > On 30 Jan 2010, at 21:38, Filipus Klutiero wrote: > > >> It's unrelated to minify. There are also no JavaScript errors. However, trying >> to validate the HTML shows 25 errors, which could very well explain issues, >> even if Tiki probably doesn't generate a single validating page. >> >> Le janvier 30, 2010 03:32:39 PM, luci aka luciash d' being a écrit : >> >>> i smell the CSS minify is not perfect... try to switch it off on >>> Performance prefs >>> >>> luci >>> >>> On 01/30/2010 09:24 PM, Filipus Klutiero wrote: >>> >>>> Le janvier 30, 2010 02:19:51 PM, Desilets, Alain a écrit : >>>> >>>>> Hi folks, >>>>> >>>>> Just upgraded trunk to r24758, and now, the layout of all pages is >>>>> screwed up. See attached screenshot. >>>>> >>>>> Is anyone else seeing this? >>>>> >>>> I do, with thenews. I first noticed it this week, probably between 1 to 3 >>>> days ago. This doesn't happen on *all* pages; actually, I only noticed it >>>> on the HomePage, the same your screenshot had, with 2 columns, each on >>>> its side. The result, at least with thenews, is not quite the same, but >>>> it's clearly the same bug, each column taking its side (too much). >>>> >> ------------------------------------------------------------------------------ >> The Planet: dedicated and managed hosting, cloud storage, colocation >> Stay online with enterprise data centers and the best network in the business >> Choose flexible plans and management services without long-term contracts >> Personal 24x7 support from experience hosting pros just a phone call away. >> http://p.sf.net/sfu/theplanet-com >> _______________________________________________ >> Tikiwiki-devel mailing list >> Tik...@li... >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel >> > > > ------------------------------------------------------------------------------ > The Planet: dedicated and managed hosting, cloud storage, colocation > Stay online with enterprise data centers and the best network in the business > Choose flexible plans and management services without long-term contracts > Personal 24x7 support from experience hosting pros just a phone call away. > http://p.sf.net/sfu/theplanet-com > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > ---------------------------------------- > Freehosting PIPNI - http://www.pipni.cz/ > > |
From: Gary Cunningham-L. <ga...@cu...> - 2010-01-31 00:51:33
|
I didn't research much about the need for "role" in the markup (http://www.w3.org/TR/xhtml-role/) but was wondering if it could be added to #tiki-center instead of being a new div, like <div id="tiki-center" role="main">. This way there's no extra div, and role is there if it has some reason. -- Gary luci aka luciash d' being wrote: > hi, > > div[role=admin] can be probably taken out > i am unsure about #tiki-center (we rather need it for some center > content tricks) > the #wrapper and #col1 is absolutely necessary for *lite to function > properly until we drop IE6/7 support > > luci > > > On 01/31/2010 12:09 AM, Jonny Bradley wrote: > >> There were some fixes to css minify (thanks LPH and Sept) which fixed all this for me, although there are still quite a few "SUMO induced" XHTML errors in all our pages now (e.g. the role attribute in several divs now) >> >> And while we're at it, do we really need four otherwise empty divs containing the central page content? >> >> #wrapper > >> #col1 > >> #tiki-center > >> div[role=main] >> >> They can't possibly be doing anything that two divs couldn't do, surely? (and that's without feature_layoutshadows enabled) >> >> My 2p... >> >> jonny >> >> On 30 Jan 2010, at 21:38, Filipus Klutiero wrote: >> >> >> >>> It's unrelated to minify. There are also no JavaScript errors. However, trying >>> to validate the HTML shows 25 errors, which could very well explain issues, >>> even if Tiki probably doesn't generate a single validating page. >>> >>> Le janvier 30, 2010 03:32:39 PM, luci aka luciash d' being a écrit : >>> >>> >>>> i smell the CSS minify is not perfect... try to switch it off on >>>> Performance prefs >>>> >>>> luci >>>> >>>> On 01/30/2010 09:24 PM, Filipus Klutiero wrote: >>>> >>>> >>>>> Le janvier 30, 2010 02:19:51 PM, Desilets, Alain a écrit : >>>>> >>>>> >>>>>> Hi folks, >>>>>> >>>>>> Just upgraded trunk to r24758, and now, the layout of all pages is >>>>>> screwed up. See attached screenshot. >>>>>> >>>>>> Is anyone else seeing this? >>>>>> >>>>>> >>>>> I do, with thenews. I first noticed it this week, probably between 1 to 3 >>>>> days ago. This doesn't happen on *all* pages; actually, I only noticed it >>>>> on the HomePage, the same your screenshot had, with 2 columns, each on >>>>> its side. The result, at least with thenews, is not quite the same, but >>>>> it's clearly the same bug, each column taking its side (too much). >>>>> >>>>> >>> ------------------------------------------------------------------------------ >>> The Planet: dedicated and managed hosting, cloud storage, colocation >>> Stay online with enterprise data centers and the best network in the business >>> Choose flexible plans and management services without long-term contracts >>> Personal 24x7 support from experience hosting pros just a phone call away. >>> http://p.sf.net/sfu/theplanet-com >>> _______________________________________________ >>> Tikiwiki-devel mailing list >>> Tik...@li... >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel >>> >>> >> ------------------------------------------------------------------------------ >> The Planet: dedicated and managed hosting, cloud storage, colocation >> Stay online with enterprise data centers and the best network in the business >> Choose flexible plans and management services without long-term contracts >> Personal 24x7 support from experience hosting pros just a phone call away. >> http://p.sf.net/sfu/theplanet-com >> _______________________________________________ >> Tikiwiki-devel mailing list >> Tik...@li... >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel >> >> ---------------------------------------- >> Freehosting PIPNI - http://www.pipni.cz/ >> >> >> > > ------------------------------------------------------------------------------ > The Planet: dedicated and managed hosting, cloud storage, colocation > Stay online with enterprise data centers and the best network in the business > Choose flexible plans and management services without long-term contracts > Personal 24x7 support from experience hosting pros just a phone call away. > http://p.sf.net/sfu/theplanet-com > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > > ------------------------------------------------------------------------ > > > No virus found in this incoming message. > Checked by AVG - www.avg.com > Version: 9.0.733 / Virus Database: 271.1.1/2658 - Release Date: 01/31/10 04:35:00 > > |
From: Marc L. <ma...@ma...> - 2010-01-31 18:43:13
|
I have latest trunk here: http://demo.tikiwiki.org/trunk2/ I don't see what you describe. Only thing I see is when I log in, the DIV plugins are too narrow. M ;-) On Sun, Jan 31, 2010 at 12:12 PM, Desilets, Alain <Ala...@nr...> wrote: > This AM I did a binary search and established that the bug was introduced in r24669. I I revert to r24668, everything is fine, but if I revert to r24669, the bug is back. > > The thing I don't understand is that this revision was committed 6 days ago, but I only noticed yesterday. But I SHOULD have noticed a lot earlier, because: > > - I update from svn at least once a day > - I clear my cache at least 10 times a day > - This bug is impossible to miss because it completely cripples my tiki installation and make it impossible to use. > > I wonder if there isn's a weird interaction between this bug and some other change that has occurred on my system since. For example, maybe the bug only shows when the Firefox (as opposed to the Tiki) caches have been cleaned up. > > Alain > > ------------------------------------------------------------------------------ > The Planet: dedicated and managed hosting, cloud storage, colocation > Stay online with enterprise data centers and the best network in the business > Choose flexible plans and management services without long-term contracts > Personal 24x7 support from experience hosting pros just a phone call away. > http://p.sf.net/sfu/theplanet-com > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > -- Marc Laporte http://MarcLaporte.com http://TikiWiki.org/MarcLaporte http://AvanTech.net http://OurWiki.net |
From: Filipus K. <ch...@gm...> - 2010-01-31 19:05:57
|
I see it here: http://demo.tikiwiki.org/trunk2/tiki-index.php?page=HomePage Le janvier 31, 2010 01:43:06 PM, Marc Laporte a écrit : > I have latest trunk here: > http://demo.tikiwiki.org/trunk2/ > > I don't see what you describe. > > Only thing I see is when I log in, the DIV plugins are too narrow. > > M ;-) > > > > On Sun, Jan 31, 2010 at 12:12 PM, Desilets, Alain > > <Ala...@nr...> wrote: > > This AM I did a binary search and established that the bug was introduced > > in r24669. I I revert to r24668, everything is fine, but if I revert to > > r24669, the bug is back. > > > > The thing I don't understand is that this revision was committed 6 days > > ago, but I only noticed yesterday. But I SHOULD have noticed a lot > > earlier, because: > > > > - I update from svn at least once a day > > - I clear my cache at least 10 times a day > > - This bug is impossible to miss because it completely cripples my tiki > > installation and make it impossible to use. > > > > I wonder if there isn's a weird interaction between this bug and some > > other change that has occurred on my system since. For example, maybe the > > bug only shows when the Firefox (as opposed to the Tiki) caches have been > > cleaned up. > > > > Alain > > > > ------------------------------------------------------------------------- > >----- The Planet: dedicated and managed hosting, cloud storage, colocation > > Stay online with enterprise data centers and the best network in the > > business Choose flexible plans and management services without long-term > > contracts Personal 24x7 support from experience hosting pros just a phone > > call away. http://p.sf.net/sfu/theplanet-com > > _______________________________________________ > > Tikiwiki-devel mailing list > > Tik...@li... > > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > |
From: Desilets, A. <Ala...@nr...> - 2010-01-31 19:14:30
Attachments:
tiki-layout-screwed-up-2009-01-31b.png
|
Oh, and btw, when I go to the site you mention and login as admin (using the "secret" 4-character pwd ;-)), I see the bug. See attached screenshot. -----Original Message----- From: Marc Laporte [mailto:ma...@ma...] Sent: Sunday, January 31, 2010 1:43 PM To: Tikiwiki developers Subject: Re: [Tikiwiki-devel] Layout broken in trunk? I have latest trunk here: http://demo.tikiwiki.org/trunk2/ I don't see what you describe. Only thing I see is when I log in, the DIV plugins are too narrow. M ;-) On Sun, Jan 31, 2010 at 12:12 PM, Desilets, Alain <Ala...@nr...> wrote: > This AM I did a binary search and established that the bug was introduced in r24669. I I revert to r24668, everything is fine, but if I revert to r24669, the bug is back. > > The thing I don't understand is that this revision was committed 6 days ago, but I only noticed yesterday. But I SHOULD have noticed a lot earlier, because: > > - I update from svn at least once a day > - I clear my cache at least 10 times a day > - This bug is impossible to miss because it completely cripples my tiki installation and make it impossible to use. > > I wonder if there isn's a weird interaction between this bug and some other change that has occurred on my system since. For example, maybe the bug only shows when the Firefox (as opposed to the Tiki) caches have been cleaned up. > > Alain > > ------------------------------------------------------------------------------ > The Planet: dedicated and managed hosting, cloud storage, colocation > Stay online with enterprise data centers and the best network in the business > Choose flexible plans and management services without long-term contracts > Personal 24x7 support from experience hosting pros just a phone call away. > http://p.sf.net/sfu/theplanet-com > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > -- Marc Laporte http://MarcLaporte.com http://TikiWiki.org/MarcLaporte http://AvanTech.net http://OurWiki.net ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Tikiwiki-devel mailing list Tik...@li... https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel |
From: Desilets, A. <Ala...@nr...> - 2010-01-31 19:09:02
Attachments:
tiki-layout-screwed-up-2009-01-31.png
|
I'm at trunk r24769, and I still see what's shown in the attached screen shot. - I cleared my Tiki cache - I cleared my Firefox cache I see this in both Firefox 3.5.7 and IE 7.0.5. Note that I am using an ASUS netbook with a very small screen. Maybe it only shows up on small screens? -----Original Message----- From: Marc Laporte [mailto:ma...@ma...] Sent: Sunday, January 31, 2010 1:43 PM To: Tikiwiki developers Subject: Re: [Tikiwiki-devel] Layout broken in trunk? I have latest trunk here: http://demo.tikiwiki.org/trunk2/ I don't see what you describe. Only thing I see is when I log in, the DIV plugins are too narrow. M ;-) On Sun, Jan 31, 2010 at 12:12 PM, Desilets, Alain <Ala...@nr...> wrote: > This AM I did a binary search and established that the bug was introduced in r24669. I I revert to r24668, everything is fine, but if I revert to r24669, the bug is back. > > The thing I don't understand is that this revision was committed 6 days ago, but I only noticed yesterday. But I SHOULD have noticed a lot earlier, because: > > - I update from svn at least once a day > - I clear my cache at least 10 times a day > - This bug is impossible to miss because it completely cripples my tiki installation and make it impossible to use. > > I wonder if there isn's a weird interaction between this bug and some other change that has occurred on my system since. For example, maybe the bug only shows when the Firefox (as opposed to the Tiki) caches have been cleaned up. > > Alain > > ------------------------------------------------------------------------------ > The Planet: dedicated and managed hosting, cloud storage, colocation > Stay online with enterprise data centers and the best network in the business > Choose flexible plans and management services without long-term contracts > Personal 24x7 support from experience hosting pros just a phone call away. > http://p.sf.net/sfu/theplanet-com > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel > -- Marc Laporte http://MarcLaporte.com http://TikiWiki.org/MarcLaporte http://AvanTech.net http://OurWiki.net ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Tikiwiki-devel mailing list Tik...@li... https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel |
From: Filipus K. <ch...@gm...> - 2010-01-31 19:33:00
|
Le janvier 31, 2010 02:08:53 PM, Desilets, Alain a écrit : > I'm at trunk r24769, and I still see what's shown in the attached screen > shot. > > - I cleared my Tiki cache > - I cleared my Firefox cache > > I see this in both Firefox 3.5.7 and IE 7.0.5. It's definitely not fixed, I still get it too. > > Note that I am using an ASUS netbook with a very small screen. Maybe it > only shows up on small screens? I noticed the bug on my 1680x1050 screen. It might show a bit differently on a smaller window. > > -----Original Message----- > From: Marc Laporte [mailto:ma...@ma...] > Sent: Sunday, January 31, 2010 1:43 PM > To: Tikiwiki developers > Subject: Re: [Tikiwiki-devel] Layout broken in trunk? > > I have latest trunk here: > http://demo.tikiwiki.org/trunk2/ > > I don't see what you describe. > > Only thing I see is when I log in, the DIV plugins are too narrow. > > M ;-) > > > > On Sun, Jan 31, 2010 at 12:12 PM, Desilets, Alain > > <Ala...@nr...> wrote: > > This AM I did a binary search and established that the bug was introduced > > in r24669. I I revert to r24668, everything is fine, but if I revert to > > r24669, the bug is back. > > > > The thing I don't understand is that this revision was committed 6 days > > ago, but I only noticed yesterday. But I SHOULD have noticed a lot > > earlier, because: > > > > - I update from svn at least once a day > > - I clear my cache at least 10 times a day > > - This bug is impossible to miss because it completely cripples my tiki > > installation and make it impossible to use. > > > > I wonder if there isn's a weird interaction between this bug and some > > other change that has occurred on my system since. For example, maybe the > > bug only shows when the Firefox (as opposed to the Tiki) caches have been > > cleaned up. > > > > Alain |
From: Desilets, A. <Ala...@nr...> - 2010-02-02 13:27:44
|
Hi Stéphane, I really appreciate your help with this, so you'll understand that I am sorry to be the bearer of bad news ;-). I implemented that patch, and now the traces do print the pathes with / instead of \. Unfortunately, that does not seem to solve the problem. Note that I have cleared my Tiki and Browser caches three times just to be sure. I don't know if it can help, but Firebug reports the following 4 errors: --- Firebug reported errors: Firebug's log limit has been reached. 0 entries not shown. Preferences setsectionstate is not defined tiki-index.php()tiki-index.php (line 608) [Break on this error] $jq("document").ready(function(){ tiki-index.php (line 608) $jq is not defined [Break on this error] $jq("document").ready(function(){ tiki-index.php (line 521) $jq is not defined [Break on this error] $jq(document).ready( function() { tiki-index.php (line 555) $jq is not defined [Break on this error] $jq("document").ready(function(){ ---- And this is what my minify_css() function looks like at the moment. -- private function minify_css( $file ) { global $tikipath, $tikiroot; echo "<pre>-- headerlib.minify_css: \$file="; var_dump($file); echo "</pre>\n"; echo "<pre>-- headerlib.minify_css: \$tikipath="; var_dump($tikipath); echo "</pre>\n"; echo "<pre>-- headerlib.minify_css: \$tikiroot="; var_dump($tikiroot); echo "</pre>\n"; if (strpos($file, $tikiroot) === 0) { // $currentdir = dirname( $file ); $currentdir = str_replace('\\', '/',dirname( $file )); $content = file_get_contents( str_replace( $tikiroot, $tikipath, $file)) ; echo "<pre>-- headerlib.minify_css: file path contains \$tikirot. \$currentdir="; var_dump($currentdir); echo "</pre>\n"; // die(); } else { if ( $file[0] == '/' ) { $file = $tikipath.$file; } // $currentdir = addslashes(str_replace($tikipath, $tikiroot, dirname(realpath( $file )))); $currentdir = addslashes(str_replace($tikipath, $tikiroot, str_replace('\\', '/',dirname(realpath( $file ))))); $content = file_get_contents( $file ); echo "<pre>-- headerlib.minify_css: file path DOES NOT contains \$tikirot. \$currentdir="; var_dump($currentdir); echo "</pre>\n"; // die(); } -- -----Original Message----- From: Stephane Casset [mailto:se...@lo...] Sent: Monday, February 01, 2010 6:54 PM To: Tikiwiki developers Subject: Re: [Tikiwiki-devel] Layout broken in trunk? Le Mon, Feb 01, 2010 at 12:06:26PM -0500, Desilets, Alain écrivait : > Here: > > -- headerlib.minify_css: $file=string(16) "css/cssmenus.css" > -- headerlib.minify_css: $tikipath=string(23) "C:/wamp/www/tiki-trunk/" > -- headerlib.minify_css: $tikiroot=string(12) "/tiki-trunk/" -- > headerlib.minify_css: file path DOES NOT contains $tikirot. > $currentdir=string(30) "C:\\wamp\\www\\tiki-trunk\\css" > > Dunno of $tikiroot='"/tiki-trunk/' is normal, but that path does not > exist. The root of my tiki installation is under: Well tikiroot is supposed to be the root of your site from the HTTPD server point of view, ie you access your site with : http://server/tikiroot/tiki-index.php And tikipath is supposed to be the real location of your site on your computer Ok now I see what's happening we need to transform \\ into / so please could you test this patch and tell me if it works : Index: lib/headerlib.php =================================================================== --- lib/headerlib.php (révision 24775) +++ lib/headerlib.php (copie de travail) @@ -432,13 +432,13 @@ private function minify_css( $file ) { global $tikipath, $tikiroot; if (strpos($file, $tikiroot) === 0) { - $currentdir = dirname( $file ); + $currentdir = str_replace('\\', '/',dirname( $file )); $content = file_get_contents( str_replace( $tikiroot, $tikipath, $file)) ; } else { if ( $file[0] == '/' ) { $file = $tikipath.$file; } - $currentdir = addslashes(str_replace($tikipath, $tikiroot, dirname(realpath( $file )))); + $currentdir = addslashes(str_replace($tikipath, $tikiroot, str_replace('\\', '/',dirname(realpath( $file ))))); $content = file_get_contents( $file ); } A+ -- Stéphane Casset LOGIDÉE sàrl Se faire plaisir d'apprendre 1a, rue Pasteur Tel : +33 388 23 69 77 ca...@lo... F-67540 OSTWALD Fax : +33 388 23 69 77 http://logidee.com ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Tikiwiki-devel mailing list Tik...@li... https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel |
From: Gary Cunningham-L. <ga...@cu...> - 2010-02-02 15:23:55
|
In the current trunk on my wamp server, I have minify css turned on, and I'm getting these messages at the top of tiki-install.php (at the 'Configure General Settings' page). Notice that in the file_get_contents warnings, a lot of the path - "Documents and Settings/Administrator/My Documents/Apps/wamp/www/TikiWiki/trunk" (everything from the drive's top directory to the tiki web root- is _repeated_. (The path in the Notices is correct.) Notice: Constant ADODB_ASSOC_CASE already defined in C:\Documents and Settings\Administrator\My Documents\Apps\wamp\www\TikiWiki\trunk\installer\tiki-installer.php on line 502 Notice: Undefined index: general_settings in C:\Documents and Settings\Administrator\My Documents\Apps\wamp\www\TikiWiki\trunk\installer\tiki-installer.php on line 803 Warning: file_get_contents(C:/Documents and Settings/Administrator/My Documents/Apps/wamp/www/TikiWiki/trunk//Documents and Settings/Administrator/My Documents/Apps/wamp/www/TikiWiki/trunk/styles/lite/lite.css) [function.file-get-contents]: failed to open stream: No such file or directory in C:\Documents and Settings\Administrator\My Documents\Apps\wamp\www\TikiWiki\trunk\lib\headerlib.php on line 442 Warning: file_get_contents(C:/Documents and Settings/Administrator/My Documents/Apps/wamp/www/TikiWiki/trunk//Documents and Settings/Administrator/My Documents/Apps/wamp/www/TikiWiki/trunk/styles/layout/layout.css) [function.file-get-contents]: failed to open stream: No such file or directory in C:\Documents and Settings\Administrator\My Documents\Apps\wamp\www\TikiWiki\trunk\lib\headerlib.php on line 442 Warning: file_get_contents(C:/Documents and Settings/Administrator/My Documents/Apps/wamp/www/TikiWiki/trunk//Documents and Settings/Administrator/My Documents/Apps/wamp/www/TikiWiki/trunk/styles/layout/design.css) [function.file-get-contents]: failed to open stream: No such file or directory in C:\Documents and Settings\Administrator\My Documents\Apps\wamp\www\TikiWiki\trunk\lib\headerlib.php on line 442 -- Gary Desilets, Alain wrote: > Hi Stéphane, > > I really appreciate your help with this, so you'll understand that I am sorry to be the bearer of bad news ;-). > > I implemented that patch, and now the traces do print the pathes with / instead of \. Unfortunately, that does not seem to solve the problem. > > Note that I have cleared my Tiki and Browser caches three times just to be sure. > > I don't know if it can help, but Firebug reports the following 4 errors: > > --- Firebug reported errors: > Firebug's log limit has been reached. 0 entries not shown. Preferences > setsectionstate is not defined > tiki-index.php()tiki-index.php (line 608) > [Break on this error] $jq("document").ready(function(){ > tiki-index.php (line 608) > $jq is not defined > [Break on this error] $jq("document").ready(function(){ > tiki-index.php (line 521) > $jq is not defined > [Break on this error] $jq(document).ready( function() { > tiki-index.php (line 555) > $jq is not defined > [Break on this error] $jq("document").ready(function(){ > ---- > > And this is what my minify_css() function looks like at the moment. > > -- > private function minify_css( $file ) { > global $tikipath, $tikiroot; > echo "<pre>-- headerlib.minify_css: \$file="; var_dump($file); echo "</pre>\n"; > echo "<pre>-- headerlib.minify_css: \$tikipath="; var_dump($tikipath); echo "</pre>\n"; > echo "<pre>-- headerlib.minify_css: \$tikiroot="; var_dump($tikiroot); echo "</pre>\n"; > > if (strpos($file, $tikiroot) === 0) { > // $currentdir = dirname( $file ); > $currentdir = str_replace('\\', '/',dirname( $file )); > $content = file_get_contents( str_replace( $tikiroot, $tikipath, $file)) ; > echo "<pre>-- headerlib.minify_css: file path contains \$tikirot. \$currentdir="; var_dump($currentdir); echo "</pre>\n"; > // die(); > } else { > if ( $file[0] == '/' ) { > $file = $tikipath.$file; > } > // $currentdir = addslashes(str_replace($tikipath, $tikiroot, dirname(realpath( $file )))); > $currentdir = addslashes(str_replace($tikipath, $tikiroot, str_replace('\\', '/',dirname(realpath( $file ))))); > $content = file_get_contents( $file ); > echo "<pre>-- headerlib.minify_css: file path DOES NOT contains \$tikirot. \$currentdir="; var_dump($currentdir); echo "</pre>\n"; > // die(); > } > -- > > -----Original Message----- > From: Stephane Casset [mailto:se...@lo...] > Sent: Monday, February 01, 2010 6:54 PM > To: Tikiwiki developers > Subject: Re: [Tikiwiki-devel] Layout broken in trunk? > > Le Mon, Feb 01, 2010 at 12:06:26PM -0500, Desilets, Alain écrivait : >> Here: >> >> -- headerlib.minify_css: $file=string(16) "css/cssmenus.css" >> -- headerlib.minify_css: $tikipath=string(23) "C:/wamp/www/tiki-trunk/" >> -- headerlib.minify_css: $tikiroot=string(12) "/tiki-trunk/" -- >> headerlib.minify_css: file path DOES NOT contains $tikirot. >> $currentdir=string(30) "C:\\wamp\\www\\tiki-trunk\\css" >> >> Dunno of $tikiroot='"/tiki-trunk/' is normal, but that path does not >> exist. The root of my tiki installation is under: > > Well tikiroot is supposed to be the root of your site from the HTTPD > server point of view, ie you access your site with : > http://server/tikiroot/tiki-index.php > And tikipath is supposed to be the real location of your site on your > computer > > Ok now I see what's happening we need to transform \\ into / so please > could you test this patch and tell me if it works : > > Index: lib/headerlib.php > =================================================================== > --- lib/headerlib.php (révision 24775) > +++ lib/headerlib.php (copie de travail) > @@ -432,13 +432,13 @@ > private function minify_css( $file ) { > global $tikipath, $tikiroot; > if (strpos($file, $tikiroot) === 0) { > - $currentdir = dirname( $file ); > + $currentdir = str_replace('\\', '/',dirname( $file )); > $content = file_get_contents( str_replace( $tikiroot, $tikipath, $file)) ; > } else { > if ( $file[0] == '/' ) { > $file = $tikipath.$file; > } > - $currentdir = addslashes(str_replace($tikipath, $tikiroot, dirname(realpath( $file )))); > + $currentdir = addslashes(str_replace($tikipath, $tikiroot, str_replace('\\', '/',dirname(realpath( $file ))))); > $content = file_get_contents( $file ); > } > > A+ |
From: Stephane C. <se...@lo...> - 2010-02-04 16:09:48
|
Le Fri, Jan 29, 2010 at 04:02:26PM -0500, Marc Laporte écrivait : > Hello, > > This morning, LP & I had a meeting with SUMO. There has been a very > recent change of plan. As of now, SUMO has decided not to continue > with Tiki as their long-term base platform. They will build something > from scratch (presumably based on a framework). Since this deserves a > longer analysis/explanation, I will provide more details on everything > later. So ? :( > The good news is that most of what is upstreameable from SUMO has been > upstreamed. There are a lot of great things (minify CSS, minify js, > etc). Yes this is great, bravo to LPH for doing the job. > I apologize for this last-minute change. This was not under my control. > > > What this means for us now: > > 1- We have just removed features that were mostly for SUMO. They were > typically a bit specific and were going to become more generic over > time. Ex.: pagelist, screencast > > 2- We can push back the release schedule of Tiki5 (which was in super > accelerated mode for SUMO) Yes go back to previous planning, this is the most reasonnable thing to do IMO. > The 30-minute fix initiative at TikiFestNY was quite nice. Perhaps we > should repeat this at TikiFestConfoo 2010 > http://tikiwiki.org/TikiFestConfoo2010 > > Option 1: > ------------ > We still go for an early release, but give 10 more days for people to > finish up some things (ex.: merge logs), and we decompress the release > schedule (more Dogfood) and release 5.0 at Confoo. > > Option 2: > ------------ > Or we could go back to a normal schedule, and start the feature freeze > at Confoo. +1 for option 2 of course A+ -- Stéphane Casset LOGIDÉE sàrl Se faire plaisir d'apprendre 1a, rue Pasteur Tel : +33 388 23 69 77 ca...@lo... F-67540 OSTWALD Fax : +33 388 23 69 77 http://logidee.com |