From: Jonny B. <tw...@no...> - 2009-10-08 14:06:57
|
Hi Jyhem and all So are you implying that i've volunteered for this? :) Ok, doing it now (done) - here are other places that might need to be changed... (i don't have time to check fully, i'm afraid) lib/modules/modlib.php - line 214 - check_groups() lib/wiki-plugins/wikiplugin_group.php - line 69 - assumes "everybody who is registered is anonymous" lib/userslib.php - line 1791 - get_tracker_usergroup() (as Jyhem spotted) tiki-emulate_groups_switch.php - line 37 - again as Jyhem spotted modules/mod-func-groups_emulation.php - line 37 - very similar to above... Hopefully no one's managed to do this in a Smarty template(!) - i only searched in PHP files. jb On 8 Oct 2009, at 13:59, Jean-Marc Libs wrote: > I think you got it all right. > > There may also need to give a look to the $groups[] = 'Anonymous'; > line in get_tracker_usergroup function in lib/userslib.php > > There also is some stuff in tiki-emulate_groups_switch.php but I can > handle that after you make your changes (removal of lines 37 to 40). > > Thanks! > Jyhem > > On Thu, Oct 8, 2009 at 1:58 PM, Jonny Bradley <tw...@no...> wrote: >> >> Hi Chealer and all >> >> It all depends (afaics) on whether you want registered to see >> _everything_ anon can, _plus_ other stuff (as was situation >> previously) or, you want registered to see _different_ stuff from >> anon. >> >> As it is again now (r22098) you can't use perms to make thing >> disappear when you log in, only more stuff appear (right?) but before >> that (after r21822) you could, the only thing missing was an upgrade >> script to include anon in reg (and changes to profiles that might >> need >> this). >> >> This (no default inclusion) seems like the best solution to me, as it >> means there's less hidden hard-coded logic in there, which often >> makes >> it hard to predict what's going on with perms. >> >> If no one else does, i'll add this later sometime (unless i've got >> this all wrong ;) >> >> jonny >> >> (and i think i have to change something in tiki-objectpermissions.php >> too) >> >> >> >> On 7 Oct 2009, at 21:38, Filipus Klutiero wrote: >> >>> Thank you Xavi. >>> >>> I'm rolling back this change. >>> I see 2 advantages in the change: >>> 1. "Anonymous" is not the same as "Anyone". You wouldn't expect a >>> registered user to be called anonymous. We do have a terminology >>> problem. >>> 2. Admins are given the choice to put Registered users in the >>> Anonymous >>> group or not. This is plain more flexible. >>> >>> However, neither of these is important enough to warrant major >>> breakage >>> to most installs. Furthermore, I like having "Anyone" included in >>> Registered by default, if only to be consistent with Admins >>> including >>> Registered by default. >>> >>> I don't oppose another try at this, but I'd recommend to announce >>> your >>> plan first, possibly with a patch. >>> >>> Xavier de Pedro a écrit : >>>> Hi Philippe: >>>> >>>> That came from the thread: >>>> >>>> "Follow Up on "menu item perms" + get_user_groups() function", >>>> from >>>> Sept 11, 2009. >>>> >>>> http://www.nabble.com/Follow-Up-on-%22menu-item-perms%22-%2B-get_user_groups%28%29-function-td25408529.html >>>> >>>> To avoid further confusion: I didn't propose this change; I just >>>> copied >>>> to the documentation page for Tiki4, since it seemed to me that it >>>> was >>>> kind of agreed in the list, and I would forgot later to report >>>> about it. >>>> >>>> Xavi >>>> >>>> >>>> >>>> En/na Filipus Klutiero ha escrit: >>>> >>>>> Hi Xavi, >>>>> sorry, what I meant is that I'd like to see discussion about this. >>>>> Could >>>>> you give a link to the relevant list thread? >>>>> (Maybe we can even put these links in the release notes for more >>>>> information) >>>>> >>>>> Xavier de Pedro a écrit : >>>>> >>>>> >>>>>> Hi Philippe: >>>>>> >>>>>> Yes, I just copied the message (including syntactic error, >>>>>> oups :-/ ) >>>>>> from the list messages to the doc page. Otherwise, I won't >>>>>> remember >>>>>> about that change that was reported in the list. >>>>>> >>>>>> HTH >>>>>> >>>>>> Xavi >>>>>> >>>>>> >>>>>> En/na Filipus Klutiero ha escrit: >>>>>> >>>>>> >>>>>> >>>>>>> Hi, >>>>>>> xavi added the item >>>>>>> 'Anonymous' group not included by default in 'Registered' >>>>>>> to >>>>>>> http://doc.tikiwiki.org/Tiki4#Anonymous_group_not_included_by_default_in_Registered_ >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>> The groups of users 'Anonymous' is not automatically included >>>>>>>> in other >>>>>>>> groups, and whoever sets up a tiki and wishes for >>>>>>>> "'anonymous' is >>>>>>>> included for all groups" may just include group 'anonymous' in >>>>>>>> group >>>>>>>> 'Registered'. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> Was this change discussed before? I had permission problems. >>>>>>> >>> >>> ------------------------------------------------------------------------------ >>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA >>> is the only developer event you need to attend this year. Jumpstart >>> your >>> developing skills, take BlackBerry mobile applications to market and >>> stay >>> ahead of the curve. Join us from November 9 - 12, 2009. Register >>> now! >>> http://p.sf.net/sfu/devconference >>> _______________________________________________ >>> Tikiwiki-devel mailing list >>> Tik...@li... >>> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel >> >> >> ------------------------------------------------------------------------------ >> Come build with us! The BlackBerry(R) Developer Conference in SF, CA >> is the only developer event you need to attend this year. Jumpstart >> your >> developing skills, take BlackBerry mobile applications to market >> and stay >> ahead of the curve. Join us from November 9 - 12, 2009. Register now! >> http://p.sf.net/sfu/devconference >> _______________________________________________ >> Tikiwiki-devel mailing list >> Tik...@li... >> https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel >> > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart > your > developing skills, take BlackBerry mobile applications to market and > stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > _______________________________________________ > Tikiwiki-devel mailing list > Tik...@li... > https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel |