#1926 Tracker status option always ON

BRANCH-1-9_(CVS)
open
5
2005-04-03
2005-03-30
Bernard Sfez
No

On my 1.9 from the 28/03 CVS.

On tracker admin (tiki-admin_trackers.php), no matter if
i check Show status or not, it is ALWAYS displayed in
the items list (tiki-view_tracker.php).

Discussion

  • Logged In: YES
    user_id=784615

    Can we see?
    I have no problem on my cvs ... If I set "show status", the
    status appears in the first column. If I uncheck they disappear.
    In the view tracker, the 3 status buttoms shows the trackers
    that have the selected status

     
  • Bernard Sfez
    Bernard Sfez
    2005-04-03

    Logged In: YES
    user_id=1002720

    Hi Sylvie,

    As i read your answer i tried several things...

    In fact, i constently see the status while logged as tracker
    admin... if i want or not.

    I mean the tikiwiki admin or any editor with admin perm on.

    That shouldn't be that way...

     
  • Bernard Sfez
    Bernard Sfez
    2005-04-03

    Logged In: YES
    user_id=1002720

    ok, found it.

    I have change tiki-view_tracker.tpl.

    Line 44 i have supress ;" or $tiki_p_admin_trackers eq 'y'"

    That way only if tracker status option is ON it will be
    displayed, no matter if you got admin perm or not.

    This ook very logical to me, but may be someone as a
    special reason for that. Else... commit ? :)

     
  • Bernard Sfez
    Bernard Sfez
    2005-04-03

    Logged In: YES
    user_id=1002720

    AND... you have to clear it also on Edit part of the tiki-
    view_tracker.tpl which is line 278. :)

     
  • Logged In: YES
    user_id=784615

    line 44: is only the status switch - I agree thsi line is
    wrong , it must be idem the if to display the status :
    if $tracker_info.showStatus eq 'y' or
    ($tracker_info.showStatusAdminOnly eq 'y' and
    $tiki_p_admin_trackers eq 'y')}
    I did that in 1.9 cvs

    For the status by itself, I never saw bug, it was correctly
    shown or not. Be carefull about the perms: there are 3 perms
    view_status_on, view_status_closed ....
    I fixed one case: the status is displayed even if the user
    has only one perm, like this it is different from not
    displayed status

     
    • assigned_to: nobody --> sylvieg
     
  • Bernard Sfez
    Bernard Sfez
    2005-04-03

    Logged In: YES
    user_id=1002720

    >For the status by itself, I never saw bug, it was correctly
    >shown or not. Be carefull about the perms:

    Perm as (almost) nothing to do here.
    If the creator of a tracker say :NO NEED status, then no
    status should be shown in anyway. :)