Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#1390 Last login value null with web-server based authentification

v1.8.1
open
nobody
5
2004-03-22
2004-03-19
keilun
No

The last login value for any given user is broken.
Specifically this is occurring for web-server based
authentication. I do recall this not updating broken using
regular tiki authentication as well.

Using the regular tiki authentication the last login value
would only store the first login value.

Using web-server based authentication, the last login
value never updates.

Discussion

    • status: open --> open-works-for-me
     
  • Logged In: YES
    user_id=738765

    Sorry I could only test this with normal authentification
    with 1.8CVS (which would unlikely differ from 1.8.1 on this
    topic). The behavior was as expected. A lastLogin bug was
    fixed between 1.8.0 and 1.8.1, maybe you want to retest if
    you can get the same behaviour with normal authentification now.

     
  • keilun
    keilun
    2004-03-22

    Logged In: YES
    user_id=1001970

    Ah ok. I guess my recollection of last login using regular
    tiki authentication was from 1.8.0 before I patched. I
    checked this under 1.8.1 and it works.

    Using web-server based authentication doesn't work though
    under 1.8.1. That I can assure you since it's the primary
    mode that my tiki is running under.

     
    • summary: Last login value broken --> Last login value null with web-server based authentification
    • status: open-works-for-me --> open
     
  • oudeis
    oudeis
    2005-02-18

    Logged In: YES
    user_id=1222219

    This problem still exists in 1.8.5 with web server based
    authentication. The last login date is updated in
    validate_user, but this function is never called if you use web
    server authentication. The following patch fixes this, but I am
    not sure if this is the right way to do it.

    --- tiki-setup.php_orig 2005-02-18 10:30:29.659663744
    +0100
    +++ tiki-setup.php 2005-02-17 22:25:45.277294680 +0100
    @@ -283,6 +283,7 @@
    $last_forum_visit = $tikilib->get_user_preference
    ($user, 'last_forum_visit', 0);

    $tikilib->set_user_preference($user, 'last_forum_visit',
    $now);
    + $userlib->update_lastlogin($user);
    } else {
    $last_forum_visit = $now;