Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#3874 Patch: lilypond-book: Fix TEXINPUTS environment manipulation on W32

Verified
nobody
Critical
2014-05-21
2014-02-22
Anonymous
No

Originally created by: *anonymous

Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org

lilypond-book: Fix TEXINPUTS environment manipulation on W32

Cf. <URL:https://lists.gnu.org/archive/html/lilypond-user/2014-01/msg00452.html>

Also:

Restrict lilypond-book mingw32 subprocess workaround to Python versions < 2.6

http://codereview.appspot.com/64380044

Discussion

  • Originally posted by: dak@gnu.org

    (No comment was entered for this change.)

    Owner: dak@gnu.org

     
  • Originally posted by: dak@gnu.org

    See also the responsible issue 3136.

    Labels: -Type-Enhancement Type-Critical OpSys-Windows

     
  • Originally posted by: pkx1...@gmail.com

    Patchy the autobot says: passes make, make check and a full make docs.

    Labels: -Patch-new Patch-review

     
  • Originally posted by: pkx1...@gmail.com

    Patch on countdown for Feb 26th - 06:00 GMT

    Labels: -Patch-review Patch-countdown

     
  • Originally posted by: pkx1...@gmail.com

    Patch counted down - please push

    Labels: -Patch-countdown Patch-push

     
  • Originally posted by: dak@gnu.org

    Pushed to staging as
    commit [raa89d7b8d687e42cdbf11b14dc8e0b4827a8aa9e]
    Author: David Kastrup <dak@gnu.org>
    Date:   Sat Feb 22 20:54:11 2014 +0100

        Issue 3874: lilypond-book: Fix TEXINPUTS environment manipulation on W32

    commit [r1f2bdee043a85ddca79be8ef99b206fb3a97b289]
    Author: David Kastrup <dak@gnu.org>
    Date:   Sat Feb 22 20:53:34 2014 +0100

        Restrict lilypond-book mingw32 subprocess workaround to Python versions < 2.6

    Labels: -Patch-push Fixed_2_19_3 Backport_2_18_2
    Status: Fixed

     
  • Originally posted by: dak@gnu.org

    (No comment was entered for this change.)

    Labels: -Backport_2_18_2 Fixed_2_18_2

     
  • Originally posted by: dak@gnu.org

    Pushed to stable/2.18 as
    commit [r766d34770ee974588fcc9d9fbd8122c7a9112ebc]
    Author: David Kastrup <dak@gnu.org>
    Date:   Sat Feb 22 20:54:11 2014 +0100

        Issue 3874: lilypond-book: Fix TEXINPUTS environment manipulation on W32
       
        (cherry picked from commit [raa89d7b8d687e42cdbf11b14dc8e0b4827a8aa9e])

    commit [rcf034d6fa2e3490dd3d2e467f97b617e7855f18d]
    Author: David Kastrup <dak@gnu.org>
    Date:   Sat Feb 22 20:53:34 2014 +0100

        Restrict lilypond-book mingw32 subprocess workaround to Python versions < 2.6
       
        (cherry picked from commit [r1f2bdee043a85ddca79be8ef99b206fb3a97b289])

     
  • Originally posted by: dak@gnu.org

    Reopened: we currently have Python 2.4.5, and when the mingw workaround kicks in, the TEXINPUTS manipulation is missing.

    Also issue 1933 stringly suggests that the workaround is still necessary.

    Labels: -Fixed_2_19_3 -Fixed_2_18_2
    Status: Started

     
  • Originally posted by: dak@gnu.org

    Ok, since I don't want two months before we have a working lilypond-book in 2.18, and since "it does not work at all" can't actually get much worse, I tend to commit this to master right after it passing Patchy (which actually does not test it as far as can discern).

    I checked the workaround on GNU/Linux by hardwiring the test for the workaround code, and this appeared to work as intended.

    The input_dir feature appears unsupported so far in formats other than LaTeX, so I did not mess with it in other backends.  We first want to get this behavior right for LaTeX and Windows.

     
  • Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.

    Labels: -Patch-new Patch-review

     
  • Originally posted by: pkx1...@gmail.com

    Patchy the autobot says: passes make, make check and a full make docs.

     
  • Originally posted by: dak@gnu.org

    Pushed to staging as
    commit [ra06312b33d73c6a074cefb7d584e99fff09d6d62]
    Author: David Kastrup <dak@gnu.org>
    Date:   Fri Apr 4 21:51:08 2014 +0200

        Issue 3874: lilypond-book: Fix TEXINPUTS environment manipulation on W32
       
        This transfers the TEXINPUTS manipulation into the mingw32 workaround
        where it was not previously being done.

    commit [r3606a52041117a0ce85b32e5439ef6b996ae9fd0]
    Author: David Kastrup <dak@gnu.org>
    Date:   Fri Apr 4 17:51:15 2014 +0200

        Revert "Restrict lilypond-book mingw32 subprocess workaround to Python versions < 2.6"
       
        This reverts commit [r1f2bdee043a85ddca79be8ef99b206fb3a97b289].

    Labels: -Patch-review Fixed_2_19_4 Backport_2_18_3
    Status: Fixed

     
  • Originally posted by: fedel...@gmail.com

    I've verified it by compiling the musicological example of Usage with latest dev version 2.19.6. It compiles fine but I get a programming error: file name not normalized. Probably not related to this issue though

    Status: Verified

     
  • Originally posted by: dak@gnu.org

    Yeah, I am annoyed at this one.  I think the right solution would be to actually descend into the directory in question, compile there without any directory component to the path, and get back out again afterwards.

    That's probably less finicky than getting whatever pseudo-absolute directory name quoted in a TeX-compatible manner.

     
  • Originally posted by: julien.r...@gmail.com

    My first approach at fixing issue 3136 avoided TEXINPUTS. Looking back at http://codereview.appspot.com/7201047 patchset 1, it was just a matter of changing directory at the right time (after the initial latex test run instead of before it). I don't remember if this approach was sufficient though.