Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#3827 remove the necessity to have a \layout block in a \markup \score...

Verified
nobody
Enhancement
2014-03-29
2014-01-27
Anonymous
No

Originally created by: *anonymous

Originally created by: Elu...@gmail.com
Originally owned by: dak@gnu.org

the correct way to enter a score in a markup is

  \markup \score{ {...} \layout{}}

where \layout{} is mandatory but probably empty in most cases.

the warning issued

  "warning: no systems found in \score markup, does it have a \layout block?"

proves LP knows what should be added and could do so by itself.

Discussion

  • Originally posted by: dak@gnu.org

    Issue 3827: remove the necessity to have a \layout block in a \markup \score ...

    It turns out that this is not really fixable in the backend since what
    is called "layout" in the markup function definitions does not
    actually correspond to \layout but rather to \paper.  Very funny.

    So this is solved in the parser itself when reading a \score or
    \score-lines to be used in a markup or markup list by cloning
    $defaultlayout as necessary (which simulates \layout {}) whenever the
    score does not already have a \layout block.

    http://codereview.appspot.com/54210049

    Labels: Patch-new
    Owner: dak@gnu.org
    Status: Started

     
  • Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.

    Labels: -Patch-new Patch-review

     
  • Originally posted by: pkx1...@gmail.com

    Patchy the autobot says: passes make, make check and a full make docs.

     
  • Originally posted by: pkx1...@gmail.com

    Patch on countdown for Feb 14th - 06:00 GMT

    Labels: -Patch-review Patch-countdown

     
  • Originally posted by: pkx1...@gmail.com

    Patch counted down - please push.

    NB: Is there any documentation needed for this?

    Labels: -Patch-countdown Patch-push

     
  • Originally posted by: dak@gnu.org

    I think I looked around in the documentation and was unable to find any documentation of this now lifted necessity.  I might have looked in the wrong places as this seems rather surprising.

     
  • Originally posted by: dak@gnu.org

    Pushed to staging as
    commit [r00e7e96f8393ad1fe86f57cf90f4567142bd4e72]
    Author: David Kastrup <dak@gnu.org>
    Date:   Sat Feb 8 19:05:16 2014 +0100

        Issue 3827: remove the necessity to have a \layout block in a \markup \score ...
       
        It turns out that this is not really fixable in the backend since what
        is called "layout" in the markup function definitions does not
        actually correspond to \layout but rather to \paper.  Very funny.
       
        So this is solved in the parser itself when reading a \score or
        \score-lines to be used in a markup or markup list by cloning
        $defaultlayout as necessary (which simulates \layout {}) whenever the
        score is without an output definition.

    Labels: -Patch-push Fixed_2_19_3
    Status: Fixed

     
  • Originally posted by: fedel...@gmail.com

    (No comment was entered for this change.)

    Status: Verified