#414 Consistency in recommended values for @unit

closed-fixed
Martin Holmes
None
5
2012-07-16
2012-06-24
John P. McCaskey
No

att.dimensions gives the plural 'chars' and 'lines' as suggested values of @unit. But the guidelines use the singular 'char' in the examples for <space>. The examples for <gap>, <dim>, <precision>, and <del> use plural 'chars'. att.measurement gives singular 'kBit' as a suggested value for @unit. Suggested values in <milestone> and <refState> are singular.

Should these be made consistent? At minimum, the guidelines for <space> should match the sample values in att.dimensions.

Discussion

  • Martin Holmes
    Martin Holmes
    2012-06-25

    I've corrected the example for space/@unit to "chars" in PH, in rev 10610, because that's an obvious inconsistency. I'm also setting this ticket to be a bug rather than a feature request, and taking ownership of it for the moment. The broader issue of whether @unit on milestone and refState should be plural needs to be addressed, but @unit is defined separately on those elements (they aren't members of att.dimensions).

    However, it seems to me that the suggested value lists for milestone/@unit and refState/@unit are related, and should be the same, but milestone has two extra values (speaker and unnumbered). If this is an oversight, they should be brought into alignment, and in fact an attribute class could be created for this @unit (distinct from the one defined in att.dimensions). If there's a reason for the discrepancy between the value lists, then of course they'll have to remain separately defined on each element.

     
  • Martin Holmes
    Martin Holmes
    2012-06-25

    • labels: 627821 -->
    • assigned_to: nobody --> martindholmes
     
  • its very hard to see why these lists should not be the same, especially they are merely suggestions.

     
  • Kevin Hawkins
    Kevin Hawkins
    2012-07-15

    Since <refState> is used to define the way that you use <milestone>, I can't see any reason they would have different value lists. Defining an attribute class seems appropriate.

     
  • Martin Holmes
    Martin Holmes
    2012-07-16

    • status: open --> closed-fixed
     
  • Martin Holmes
    Martin Holmes
    2012-07-16

    Attribute @unit has now been moved to att.milestoneUnit; milestone and refState are now members of
    that attribute class. This centralizes the definition of the attribute and its suggested values.
    rev 10660.