Menu
▾
▴
[Tcl-bugs] [ tktoolkit-Bugs-3608074 ] <<Invoke>> binding in lib/ttk/button.tcl
|
From: SourceForge.net <no...@so...> - 2013-03-20 11:07:44
|
Bugs item #3608074, was opened at 2013-03-14 12:42 Message generated for change (Comment added) made by dkf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=3608074&group_id=12997 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 01. Bindings >Group: None >Status: Closed >Resolution: Invalid Priority: 5 Private: No Submitted By: Talvo (talvo) Assigned to: Joe English (jenglish) Summary: <<Invoke>> binding in lib/ttk/button.tcl Initial Comment: In lib/ttk/button.tcl, there are two bindings (which are later copied to TRadiobutton and TCheckbutton as well): bind TButton <Key-space> { ttk::button::activate %W } bind TButton <<Invoke>> { ttk::button::activate %W } <<Invoke>> is undocumented (it's not on the [event] manpage's list of Pre-Defined Events, or mentioned on the [ttk::button] manpage) - I'm not sure if this is an oversight, or if the binding is only there for backwards compatability or something. But it looks like it should probably either be removed, or should be documented (and the <Key-space> binding changed to [event add <<Invoke>> <Key-space>] so it's used). ---------------------------------------------------------------------- >Comment By: Donal K. Fellows (dkf) Date: 2013-03-20 04:07 Message: Use of virtual events in the tk script library: <<AltUnderlined>>: clrpick.tcl, fontchooser.tcl, tk.tcl, tkfbox.tcl, xmfbox.tcl <<Clear>>: console.tcl, entry.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<ComboboxSelected>>: demos/toolbar.tcl, ttk/combobox.tcl <<ContextMenu>>: tk.tcl <<Copy>>: console.tcl, entry.tcl, listbox.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<Cut>>: console.tcl, entry.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<Decrement>>: ttk/spinbox.tcl <<EnteredChild>>: ttk/panedwindow.tcl <<Increment>>: ttk/spinbox.tcl <<Invoke>>: ttk/button.tcl, ttk/menubutton.tcl, ttk/ttk.tcl <<LineEnd>>: console.tcl, entry.tcl, listbox.tcl, scale.tcl, scrlbar.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl, ttk/scale.tcl <<LineStart>>: console.tcl, entry.tcl, listbox.tcl, scale.tcl, scrlbar.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl, ttk/scale.tcl <<ListboxSelect>>: fontchooser.tcl, iconlist.tcl, listbox.tcl, tkfbox.tcl, xmfbox.tcl <<MenuSelect>>: demos/menu.tcl, menu.tcl <<NextChar>>: demos/entry3.tcl, demos/items.tcl, entry.tcl, iconlist.tcl, listbox.tcl, menu.tcl, scale.tcl, scrlbar.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl, ttk/scale.tcl <<NextLine>>: console.tcl, entry.tcl, iconlist.tcl, listbox.tcl, menu.tcl, scale.tcl, scrlbar.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl, ttk/scale.tcl <<NextPara>>: scale.tcl, scrlbar.tcl, text.tcl, tk.tcl, ttk/scale.tcl <<NextWindow>>: dialog.tcl, tk.tcl <<NextWord>>: entry.tcl, listbox.tcl, scale.tcl, scrlbar.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl, ttk/scale.tcl <<Paste>>: console.tcl, entry.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<PasteSelection>>: entry.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<PrevChar>>: demos/entry3.tcl, entry.tcl, iconlist.tcl, listbox.tcl, menu.tcl, scale.tcl, scrlbar.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl, ttk/scale.tcl <<PrevLine>>: console.tcl, entry.tcl, iconlist.tcl, listbox.tcl, menu.tcl, scale.tcl, scrlbar.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl, ttk/scale.tcl <<PrevPara>>: scale.tcl, scrlbar.tcl, text.tcl, tk.tcl, ttk/scale.tcl <<PrevWindow>>: dialog.tcl, tk.tcl, ttk/combobox.tcl <<PrevWord>>: entry.tcl, listbox.tcl, scale.tcl, scrlbar.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl, ttk/scale.tcl <<Redo>>: text.tcl, tk.tcl <<SelectAll>>: entry.tcl, listbox.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<SelectLineEnd>>: entry.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<SelectLineStart>>: entry.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<SelectNextChar>>: entry.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<SelectNextLine>>: listbox.tcl, text.tcl, tk.tcl <<SelectNextPara>>: text.tcl, tk.tcl <<SelectNextWord>>: entry.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<SelectNone>>: entry.tcl, listbox.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<SelectPrevChar>>: entry.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<SelectPrevLine>>: listbox.tcl, text.tcl, tk.tcl <<SelectPrevPara>>: text.tcl, tk.tcl <<SelectPrevWord>>: entry.tcl, spinbox.tcl, text.tcl, tk.tcl, ttk/entry.tcl <<ThemeChanged>>: fontchooser.tcl, ttk/ttk.tcl <<TkFontchooserFontChanged>>: fontchooser.tcl <<TkFontchooserVisibility>>: console.tcl, demos/fontchoose.tcl, demos/text.tcl, fontchooser.tcl <<ToggleSelection>>: tk.tcl, ttk/entry.tcl, ttk/treeview.tcl <<TraverseIn>>: entry.tcl, spinbox.tcl, tk.tcl, ttk/combobox.tcl, ttk/entry.tcl, ttk/utils.tcl <<TraverseOut>>: tk.tcl, ttk/utils.tcl <<TreeviewClose>>: ttk/treeview.tcl <<TreeviewOpen>>: demos/tree.tcl, ttk/treeview.tcl <<Undo>>: text.tcl, tk.tcl ---------------------------------------------------------------------- Comment By: Jan Nijtmans (nijtmans) Date: 2013-03-20 04:02 Message: How about ?: <http://core.tcl.tk/tk/info/bb6cac1113> Could this do any harm? ---------------------------------------------------------------------- Comment By: Jan Nijtmans (nijtmans) Date: 2013-03-20 03:27 Message: >OK, so we should document it Agreed. <<Invoke>> should be documented as an event which is not defined by Tk, only used. And - indeed - for consistancy, I would add <<Invoke>> bindings to other relevant widgets as well (button, listbox and menu) > Do not add <Key-space> as a synonym for <<Invoke>>, that > would be incorrect. Such addition would mean that the default binding for <Key-space> changes, a potentional incompatible change which therefore cannot be done in Tk 8.6. ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2013-03-20 02:44 Message: OK, so we should document it. That's fine. We could also add it to the bindings put on ordinary *buttons, etc. as it isn't mapped to a key sequence. The docs really are just a “these are the virtual events used in Tk”, and could probably do with some updating anyway. I suggest something like this shell magic to find things worthy of mentioning (and where to look for the uses of the events): grep '<<[a-zA-Z0-9]*>>' $(find tk/library -name '*.tcl') | sed 's/\([^:]*\):.*\(<<.*>>\).*/\2: \1/' | sort -u Don't know if I'll get to doing such an audit in the near future. :-( ---------------------------------------------------------------------- Comment By: Joe English (jenglish) Date: 2013-03-19 14:24 Message: <<Invoke>> event bindings are used for mnemonic activation and for accelerators, for exaqmple: bind $dlg <KeyPress-Escape> [list event generate $dlg.cancel <<Invoke>>] See also the keynav package (which was a part of Tile that Jeff left behind when executing TIP#248), https://github.com/jenglish/tile-extras/blob/master/keynav.tcl Please do not remove the <<Invoke>> binding from library/ttk/*.tcl, that will break user code that relies on it. Do not add <Key-space> as a synonym for <<Invoke>>, that would be incorrect. ---------------------------------------------------------------------- Comment By: Jan Nijtmans (nijtmans) Date: 2013-03-19 07:36 Message: <<Invoke>> cannot be added to the virtual events, at least not until Tk 8.7. I see no added value in defining a virtual event which is equivalent to <Key-space>, so I would suggest removing it. Joe? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=3608074&group_id=12997 |