Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#5184 msgcat -1.5.0.tm error on windows XP

obsolete: 8.5.13
closed-fixed
5
2013-02-14
2013-02-13
No

msgcat.tm throws an error on windows xp if
HKEY_CURRENT_USER\Control Panel\International
does not exist.
this problem exists in 8.5.13 and 8.6.0

I discovered this problem on [clock format [clock seconds] -format ...]

line 553:
set key {HKEY_CURRENT_USER\Control Panel\International}
if {([registry values $key "LocaleName"] ne "") ...

Discussion

  • Jan Nijtmans
    Jan Nijtmans
    2013-02-14

    • assigned_to: dkf --> oehhar
     
  • Jan Nijtmans
    Jan Nijtmans
    2013-02-14

    Suggested fix in branch "bug-3604576"

     
  • Jan,
    thank you, careing. I was on business trip yesterday, saw it only today.

    About the patch:
    The line which failes was just designed to catch the issue which shows up.
    I normally prefer to avoid catch to not pollute the error stack.
    I also try to not catch more than necessary.

    I propose to change the solution, that:
    - only the "registry get" is catched
    - if it fails, the second method following is used.
    This is necessary, because under older Windows Version, this was the prefered method

    I will change this on fossil and you are invited to review.

    Thank you,
    Harald

     
  • Jan Nijtmans
    Jan Nijtmans
    2013-02-14

    > - if it fails, the second method following is used.
    > This is necessary, because under older Windows Version, this was the
    > prefered method
    In this case, if the $key is missing, the next method will fail as well,
    so there is no reason to continue at all. On your other remark
    (catch not more than necessary) I agree with that.

     
  • You are right.
    Modified version with finer granulated catch uploaded.

    Both versions are ok for me.

    Feel free to merge to trunks,
    Harald

     
  • Jan Nijtmans
    Jan Nijtmans
    2013-02-14

    I tested it, and it looks good to me.

    Merged to core-8-5-branch and trunk now.

     
  • Jan Nijtmans
    Jan Nijtmans
    2013-02-14

    • status: open --> closed-fixed