#3977 useless call to endgrent()/endpwent()

obsolete: 8.5.2
closed-fixed
5
2009-08-02
2008-04-14
No

in unix/tclUnixFCmd.c, GetGroupAttribute() and GetOwnerAttribute() make calls to non-wrapped POSIX calls endpwent() and endgrent().
These two calls are marked to be avoided by the Open Group http://www.opengroup.org/onlinepubs/009695399/functions/getgrent.html
Moreover, the actual calls are useless since TclpGetPwUid() and TclpGetGrUid() do use the newer grgetpw() and grgetgid().

Solution : remove the calls.

Discussion

    • labels: --> 37. File System
    • milestone: --> obsolete: 8.5.2
    • assigned_to: nobody --> hobbs
     
    • assigned_to: hobbs --> dkf
     
  • Looks like those are hangovers from when we did use getpwent() and getgrent(), and serve no purpose now.
    Fixed on HEAD.

     
  • Backported to 8.5 branch

     
    • status: open --> closed-fixed