#3612 [source] is slower since 8.4.13 (winXP)

obsolete: 8.4.14
closed-duplicate
miguel sofer
5
2007-09-13
2007-01-04
Eric Boudaillier
No

Since I installed ActiveTcl8.4.14, the startup of my application is slower. After tracing, I found that it is [source] which is really slower.

It seems that ActiveTcl8.4.14 is compiled with TIP280.
I think that the comment in tclBasic.c rev 1.75.2.26, in EvalEx(), line 3821 is false, and the call to Tcl_FSGetNormalizedPath() slow down things.

Discussion

  • Logged In: YES
    user_id=493507
    Originator: YES

    I just compiled core-8-4-14 (so without TIP280) and installed over ActiveTcl8.4.14, and this is also slow. So this is not related to TIP280.

     
    • summary: [source] is slower with TIP280 --> [source] is slower since 8.4.14
     
    • summary: [source] is slower since 8.4.14 --> [source] is slower since 8.4.13
     
  • Logged In: YES
    user_id=493507
    Originator: YES

    Okay, now I tested with AS8.4.13. This is also slower than with AS8.4.12 (the distribution I used before installing 8.4.14).
    The number of sourced files is the same with both (206 files). Most are pkgIndex files.
    All these files are sourced in 117ms with AS8.4.12, and in 449ms with AS8.4.13.

    I can not find differences between 8.4.12 and 8.4.13 sources (nor in AS packages) which can slow things so much.

     
  • Logged In: YES
    user_id=493507
    Originator: YES

    I have finally found the problem. This is related to the fix applied for bug 1193497: "file writable lies for certain XP".

    As noted in tclWinFile.c, [file readable] is now 5-6 times slower.
    So the slow down comes from the [file readable] call in tclPkgUnknown, library/package.tcl.

    To fix it, I moved [file readable] test in the error case.

     
  • miguel sofer
    miguel sofer
    2007-09-13

    Logged In: YES
    user_id=148712
    Originator: NO

    Closing as duplicate of known issue in 1193497

     
  • miguel sofer
    miguel sofer
    2007-09-13

    • summary: [source] is slower since 8.4.13 --> [source] is slower since 8.4.13 (winXP)
    • status: open --> closed-duplicate