#2009 apparently incorrect error msg in tcltes

obsolete: 8.4b2
closed-fixed
Kevin B KENNY
3
2003-02-15
2002-08-16
Larry W. Virden
No

around line 270 of tclUnixTest.c I see the following:

} else if (strcmp(argv[1], "fill") == 0) {
if (argc != 3) {
Tcl_AppendResult(interp, "wrong #
arguments: should be \"",
argv[0], " empty index\"", (char *)
NULL);
return TCL_ERROR;
}
The code surrounding these lines would lead me to
believe that the msg should say "fill index" rather
than empty index.

The same thing can be seen here:

} else if (strcmp(argv[1], "fillpartial") == 0) {
char buf[TCL_INTEGER_SPACE];

if (argc != 3) {
Tcl_AppendResult(interp, "wrong #
arguments: should be \"",
argv[0], " empty index\"", (char *)
NULL);
return TCL_ERROR;
}

where it would seem that empty should be fillpartial.

Discussion

  • Don Porter
    Don Porter
    2002-08-19

    • labels: 104251 --> 01. Notifier
    • priority: 5 --> 3
    • assigned_to: dgp --> kennykb
     
  • Don Porter
    Don Porter
    2002-08-19

    Logged In: YES
    user_id=80530

    That routine is for testing the Notifier.

     
  • Kevin B KENNY
    Kevin B KENNY
    2003-02-15

    Logged In: YES
    user_id=99768

    Well, yes, and I changed them. I do wonder, though, at the
    sort of mind that would find this issue. These commands
    should be called only from the test suite (they aren't present
    in a stock tclsh or wish) and the test suite calls them only
    with correct syntax. Auditing the code in the test harnesses
    is not something that I'd recommend for entertainment.

     
  • Kevin B KENNY
    Kevin B KENNY
    2003-02-15

    • status: open --> closed-fixed