#1335 Tcl_CreateTrace callback does not terminate command string c

obsolete: 8.3.1
closed-fixed
miguel sofer
5
2002-03-27
2000-10-26
Anonymous
No

OriginalBugID: 5900 Bug
Version: 8.3.1
SubmitDate: '2000-06-14'
LastModified: '2000-06-14'
Severity: MED
Status: UnAssn
Submitter: welch
ChangedBy: welch
OS: All
FixedDate: '2000-10-25'
ClosedDate: '2000-10-25'

You need to run TclX to see this bug, but the callback made via
Tcl_CreateTrace passes in a command argument that is no longer
null-terminated at the end of the command. Instead you see the
rest of the script. This probably occurred in the effort to
remove "null hammering".

To see, take this script:

proc someProc {} {}

cmdtrace on noeval
someProc
someProc
someProc
cmdtrace off

And run it from the command line with Tcl X:

./tcl trace.test
1: someProc\nsomeProc\nsomeProc\ncmdtrace off\n
1: someProc\nsomeProc\ncmdtrace off\n
1: someProc\ncmdtrace off\n
1: cmdtrace off\n

In this simple case, the string should terminate at the \n

This has been broken since 8.2, we think. It would be nice to fix
for Tcl 8.3.2 and TclPro 1.4

Discussion

  • Don Porter
    Don Porter
    2001-01-26

    Patch 103420 has been proposed as a fix for this bug.

     
    • labels: 104246 --> 45. Parsing and Eval
     
  • miguel sofer
    miguel sofer
    2001-05-04

    • assigned_to: nobody --> msofer
     
  • miguel sofer
    miguel sofer
    2001-05-21

    Logged In: YES
    user_id=148712

    Related patches: #403420 & #403430

     
  • miguel sofer
    miguel sofer
    2001-12-10

    Logged In: YES
    user_id=148712

    David Knoll proposed a patch for this bug [Patch 403420].
    The patch has been updated to current HEAD and is provided
    here as 219362.patch

    The comments in the original patch were:
    "all we've done here is substitute a new and more accurate
    string length value in lieu of 'bytesLeft'.
    parse.commentStart and parse.commentSize could probably also
    be used to prevent any leading comments from being passed to
    the tclTrace callback."

     
  • miguel sofer
    miguel sofer
    2001-12-10

    proposed patch

     
    Attachments
  • miguel sofer
    miguel sofer
    2002-03-27

    Logged In: YES
    user_id=148712

    Patch committed; how did I forget?

     
  • miguel sofer
    miguel sofer
    2002-03-27

    • status: open --> closed-fixed