Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#1267 Undo of typing (subject, description) not working on Linux

Release_1.3.19
closed
None
linux
1
2012-10-21
2012-08-30
Aaron Wolf
No

Works on my Mac, but on Linux, if I accidentally change the subject of a task or if I type a bunch in a description and want to undo, it doesn't work.

Discussion

  • Frank Niessink
    Frank Niessink
    2012-08-30

    A fix was made and checked into the source code repository of Task Coach. The fix will be part of the next release. You will get another notification when that release is available with the request to install the new release and confirm that your issue has indeed been fixed.

    If you like, you can download a recent build from http://www.fraca7.net/TaskCoach-packages/latest_bugfixes.py to test the fix before the next release is available.

    Because a fix has been made for this bug report, the priority of this report has been lowered to 1 and its resolution has been set to 'Fixed'. Please keep the status of the bug report 'Open' until the next release is available to prevent duplicate bug reports.

    Thanks, Task Coach development team

     
  • Frank Niessink
    Frank Niessink
    2012-08-30

    This is functionality provided by the native text controls on Windows and Mac, but on Linux (tested on Ubuntu) the native text control doesn't provide that functionality. So I've added a home grown undo/redo capability to the text controls on Linux.

     
  • Aaron Wolf
    Aaron Wolf
    2012-08-31

    Not quite working right.

    If I either add or delete text from a subject, then undo works as expected. But if I add some text in a description that already had content, then undo removes the ENTIRE description!

    This is now how it should work. It should only undo the recent change.

    The whole loss can be undone by going to the edit menu to choose undo (because using the menu sets the changes for the item and then undo isn't just text-based, it's undoing the state change of the item). But this is just a workaround.

     
    Last edit: Aaron Wolf 2012-10-01
  • Aaron Wolf
    Aaron Wolf
    2012-10-06

    I just lost a good bunch of work because I was typing and editing and then pressed undo. Instead of undoing the latest thing, it deleted everything, as I mentioned before. I had to revert to the version from when I last closed the editor.

     
  • Aaron Wolf
    Aaron Wolf
    2012-10-06

    • priority: 5 --> 6
     
  • Frank Niessink
    Frank Niessink
    2012-10-07

    So this is not fixed in release 1.3.19?

     
  • Aaron Wolf
    Aaron Wolf
    2012-10-07

    No not fixed adequately. It doesn't work as one would expect. All other programs undo only changes the last typing since some short idle time or something like that. Task Coach 1.3.19 on Linux DELETES all the text if an undo is pressed, even if most of the text was a year old and the new change was just minor.

     
  • Aaron Wolf
    Aaron Wolf
    2012-10-07

    • milestone: Release_1.3.18 --> Release_1.3.19
     
  • Frank Niessink
    Frank Niessink
    2012-10-08

    I'll see what I can do. Please note that I'm adding a capability here, not fixing a bug.

     
  • Frank Niessink
    Frank Niessink
    2012-10-08

    The current implementation of undo was indeed broken. Revision 5610 should fix this.

    • status: open --> fixed
    • priority: 6 --> 1
     
    Last edit: Frank Niessink 2012-10-08
  • Aaron Wolf
    Aaron Wolf
    2012-10-09

    • status: fixed --> open
    • priority: 1 --> 5
     
  • Aaron Wolf
    Aaron Wolf
    2012-10-09

    Sorry, same behavior on my KDE Ubuntu system. Open an existing note, click in the description, cntl-z deletes all the content regardless of whether I even made a single modification.
    version 5610.

    So this isn't an issue of creating a new feature, this is stopping a behavior that is fundamentally dysfunctional. Removing undo would be better than this. Having normal undo would be expected though.

     
  • Frank Niessink
    Frank Niessink
    2012-10-13

    My previous fix was incomplete. Revision 5617 should fix this completely.

     
  • Aaron Wolf
    Aaron Wolf
    2012-10-14

    Ok, it now works great!

    We still need to clarify the way we mark "pending" vs "fixed" etc. because I tried it. It is NOT pending my verification, that's done. But it remains "unreleased" so we need a way to mark verified-as-fixed-but-unreleased

     
  • Aaron Wolf
    Aaron Wolf
    2012-10-14

    • status: open --> fixed
    • priority: 5 --> 1
     
  • Frank Niessink
    Frank Niessink
    2012-10-14

    • status: fixed --> fixed-and-verified
     
  • Frank Niessink
    Frank Niessink
    2012-10-21

    • status: fixed-and-verified --> closed