RE: [Syllable-developer] ext2fs

[Kristian V. <kri...@xe...>]

> All is well and so on.
> The driver is read-only and ready to go. If you want it get it from 
> http://www.hut.fi/~kurre/ext2.tar.gz

Nice :)  In case you havn't guessed, an ext2fs driver will be very useful
(Did I mention that?) :)  I know it will save a lot of people a lot of
hassle
involving FAT partitions and rebooting, myself included :)

I'll try it out tonight & let you know if I run into any problems.
 
> Some remarks:
> 	- It's slow as hell because of extensive debug output. 
>	  Speed is pretty ok with that turned off.

Your best bet is to use the kerndbg() macro which is defined in
<atheos/kdebug.h>  You can control the level of output with the DEBUG_LEVEL
constant, and switch debug output off completely if you do not define the
ENABLE_DEBUG constant.  Saves you the trouble of having to go through your
code and comment out all those printk()'s!

> 	- The debugging in on because I haven't tested it very 
>	  thoroughly. It seems to work though.

Just looking at your code I can't see any Syllable specific problems E.g.
you
use memcpy() correctly, the probe function looks fine, you fill in the FS
ops
properly, return value ranges seem correct etc.

> And about the kernel; why does it search shared libraries 
> from cwd? Doesn't seem too secure to me..
> - -- 
> Kurre

Thats the least of our problems currently; permissions are largly ignored
and
chroot() has an open Bugtraq advisory against it (Seriously;
http://www.securityfocus.com/archive/1/254747 )  This is why you should not
use
Syllable with publicly available servers running :)

--
Vanders
http://syllable.sourceforge.net
http://www.liqwyd.com


_____________________________________________________________________
This message has been checked for all known viruses by Xenicom delivered through the MessageLabs Virus Control Centre.