Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#185 Warning message patch

closed-fixed
None
5
2007-08-31
2007-07-16
James Bigler
No

Here is a patch that can be applied to the current svn HEAD that fixes some of the issues with regards to warning printing.

I wanted to be able to do "-Wall -w512", but specifying -Wall made it ignore all the other -w options.

There was also a bug that prevented a user from turning on warnings that Swig turns off by default (-w+512 would not work). I moved the code that added the default ignore list after the arguments were parsed. This puts the default list behind any user specified one in the search order.

So the following should now work properly:

-w+512 : turns on warning 512 that is turned off by default,
default ignore list is intact.
-Wall : turns on all warnings (like before)
-Wall -w512 : turns on all warnings, turns off 512
<nothing> : previous behavior with default ignore list

Discussion

  • James Bigler
    James Bigler
    2007-07-16

    Patch to r9864

     
    Attachments
  • James Bigler
    James Bigler
    2007-07-16

    Logged In: YES
    user_id=833527
    Originator: YES

    File Added: warn-patch.txt

     
  • James Bigler
    James Bigler
    2007-08-10

    Logged In: YES
    user_id=833527
    Originator: YES

    Would it be possible to include my patch in the repository?

    Thanks,
    James

     
  • William Fulton
    William Fulton
    2007-08-31

    • assigned_to: nobody --> wsfulton
    • status: open --> closed-fixed
     
  • William Fulton
    William Fulton
    2007-08-31

    Logged In: YES
    user_id=242951
    Originator: NO

    Thanks for the patch. I've fixed the bug you pointed out, but the behaviour of -Wall is documented and correctly behaved. To achieve what you want please use the new -Wextra option that I have added, see Warnings.html and CHANGES.current file for details.