From: William S Fulton <wsf@fu...> - 2009-09-29 23:33:14
Marko Klopcic wrote:
>> Here are two problematic interface files; one with printf injection, one
>> with the Swig directive problem.
> I've fixed the printf problem. However, I'd really like doxygen stuff to move on,
> since changes are summing up in my working copy and everyting becomes even more
> difficult for a review :-(
> The Swig directive problem seems to be more tricky and I'd like to do it on
> a committed working copy.
> I think there is not much risk if you review few changes in common
> sources files, and simply apply patch to files in DoxygenTranslator directory,
> where reformatting was done.
I've taken your patch with heaps of formatting changes and created a new
one which removes the whitespace changes. I think this is suitable for
review now. Hopefully Olly has a moment to look at it. I had a look and
made some minor mods after reviewing it and added that as another patch.
I can't see anything wrong with the mods, so suggest we commit.
Please apply this latest patch to your copy of trunk and use this as the
basis of changes going forwards. And please set your editor to conform
to our formatting requirements. Once we have committed this change, I'll
probably auto format all of doxygen code as somehow the really awful
formatting of the code in this branch has slipped through the reviews
and makes further changes messy.