From: Olly B. <ol...@su...> - 2006-09-23 06:20:11
|
On 2006-09-23, Kevin Ruland <kr...@su...> wrote: > I think it will take quite a bit of baking to make this php branch > viable. It will be up to Olly if it makes it onto head at all. Not sure I really deserve a right of veto, but I think it's the way to go eventually anyway. William's suggestion to merge it after 1.3.30 sounds good to me. > The biggest place I am having troubles is with error handling. In days > of old, the error macro would end up calling SWIG_fail; which is a > goto. For some reason, one of the test cases generated code without the > label. I think I remember noticing there's some case where the generated C/C++ wrapper function doesn't get a fail label. I forget when though. > So I had to resort to zend_error. Which is another problem, > zend_error is pretty brutal and doesn't give the wrapper method an > opportunity to clean up. This is something which requires some serious > thinking. For PHP5, perhaps we should consider throwing an exception instead? Cheers, Olly |