From: Kris T. <kri...@gm...> - 2016-01-09 08:22:05
|
>From: Thiel, Bjoern, Sent: 08 January 2016 14:29 > > I have a CMakeLists.txt in order to build swig including Joel's Matlab module > with MSVC (Visual Studio) on https://github.com/bjoernthiel/swig . Hi Bjoern Great. questions: - wouldn't it be better to use FindBISON.cmake? - you're defining SWIG_CXX etc at the start. Are you actually using those? - why do you insist on replacing flags to static-runtime for MSVC? I'd leave this to the user. I'd add an INSTALL target. Of course, this doesn't include anything of the examples nor test-suite, but I'd vote for including this anyway as a first step. It at least allows developers to more easily experiment with changing SWIG. Kris |