#1084 Regression: Renaming a constructor broken for python

closed-fixed
Haoyu Bai
python (259)
5
2010-04-25
2010-04-12
No

While trying to build wxPython, I ran into this bug. The attached test case was broken by the Python3K support code merged in Revision 10834.

Discussion

  • diff adding the test case

     
    Attachments
  • Great, so the add button does not add the attachment but the bug entry. :-)
    I will add another attachment with the difference in the generated code.

    This regression was introduced in 1.3.37 as it seems so it was not noticed for quite a wile.

     
  • Difference in generated code from good to bad

     
    Attachments
  • In case anybody ever cares (it could be me when hitting the next bug), this is the script I used with git bisect. I also had to build a local bison installation (I used the version from Debian lenny/stable) as otherwise bison would cause the build to fail. Otherwise, it looks like every version was built fine (from 1.3.32 onwards).

    #! /bin/sh

    set -x

    cleanup() {
    rm -f Tools/config/config.guess Tools/config/config.sub
    }
    trap cleanup 0

    ./autogen.sh || exit 125
    ./configure --without-mzscheme --without-chicken || exit 125
    rm -f swig
    make -j5 || make || exit 125
    rm -f `find Examples/test-suite -name constructor_rename_wrap.*`
    rm -f `find Examples/test-suite -name constructor_rename.py`
    make -C Examples/test-suite/python constructor_rename.cpptest
    (
    cd Examples/test-suite/python
    python -c "import constructor_rename" || exit 125
    python constructor_rename_runme.py
    )
    code="$?"

    if [ "$code" -eq 0 ]; then
    exit 0
    fi

    make clean-source
    exit "$code"

     
  • Haoyu Bai
    Haoyu Bai
    2010-04-25

    Fixed in latest commit. Thanks for the patch!

     
  • Haoyu Bai
    Haoyu Bai
    2010-04-25

    • assigned_to: nobody --> bhy
    • status: open --> closed-fixed
     
  • Thanks for fixing it so fast. :-)