Hi Sebastien!


On Monday 05 March 2012 15:58:07 Sebastien Caty wrote:

> I can confirm that SVS doesn't build properly against Samba 3.6.3, it

> still works with samba 3.5.12 (using QT 4.7.4).

>

> I have found one change so far :

> http://lists.samba.org/archive/samba-cvs/2011-April/102229.html

>

> The open function has been renamed to open_fn. The fix for that is easy :

>

> struct vfs_fn_pointers svs_fn_pointers = {

> .connect_fn = svs_connect,

> .disconnect = svs_disconnect,

> - .open = svs_open,

> + .open_fn = svs_open,

> .close_fn = svs_close,

> .rename = svs_rename,

> .unlink = svs_unlink

> };

Oh, yes, that's what I already *thought*, but I didn't want to suggest it untested / unchecked :).


> I'll see if I can find why init_samba_module broke.

Regarding the second one... it seems they changed the return value to be 'int' instead of 'NTSTATUS' now (since smb_register_vfs() apperently returns an int now).


So a quick test exchanging this:


NTSTATUS init_samba_module(void)

{

#if defined(SVS_SCANNER_CLAMAV)

return smb_register_vfs(SMB_VFS_INTERFACE_VERSION, "libsvs_clamav", &svs_fn_pointers);

#else

return smb_register_vfs(SMB_VFS_INTERFACE_VERSION, "libsvs_unknown", &svs_fn_pointers);

#endif

}


with:


NTSTATUS init_samba_module(void)

{

#if defined(SVS_SCANNER_CLAMAV)

return smb_register_vfs(SMB_VFS_INTERFACE_VERSION, "libsvs_clamav", &svs_fn_pointers);

#else

return smb_register_vfs(SMB_VFS_INTERFACE_VERSION, "libsvs_unknown", &svs_fn_pointers);

#endif

}


in the /* Samba 3.5 and 3.6 */ branch would probably help me solving it!


But then again, I need to find out the right VFS version when it changed, that is the correct value for SMB_VFS_INTERFACE_VERSION to switch the API...


I'm installing a new Debian 6.0.4 VM right now :)!


Cheers, René