Re: [Supertuxkart-devel] Patch for the inputs

[Lilian G. <lil...@la...>]

I did this to be consistent with dir_string but I should have made a 
fallback.


On 29/06/2013 22:29, mmg wrote:
> Hi,
>
> I do not own a gamepad with triggers so I cannot test that this part 
> works, but everything else looks good.
>
> There is only one part that worries me a little, in deserialisation :
>
>         if (range_string == NULL)
>         {
>             printf("WARNING: IT_STICKMOTION without range, ignoring.\n");
>             return false;
>         }
>
> This seems to mean that all previously saved input configurations will 
> fail to deserialize and will be discarded.
> I think it would be preferable instead to just fall back to the 
> previous value so that existing configs continue
> to work. Or was there a specific reason you did this?
>
> -- Auria
>
>
>
>> I made some modifications to remove the 6 axes limit and to handle the use of full axes (ex: triggers). Are you ok to integrate it ?
>>
>> Une messagerie gratuite, garantie à vie et des services en plus, ça vous tente ?
>> Je crée ma boîte mailwww.laposte.net
>>
>>
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by Windows:
>>
>> Build for Windows Store.
>>
>> http://p.sf.net/sfu/windows-dev2dev
>>
>>
>> _______________________________________________
>> Supertuxkart-devel mailing list
>> Sup...@li...
>> https://lists.sourceforge.net/lists/listinfo/supertuxkart-devel
>