Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#1 Fix (?) to Xlib async errors, plus some other things

open
nobody
None
5
2007-05-26
2007-05-26
No

See this bug:
crash: Xlib: unexpected async reply
https://sourceforge.net/tracker/index.php?func=detail&aid=1709387&group_id=135323&atid=732531

The cause of this bug is the use of QMessageBox inside a non-main thread. So, as a quick hack, I'm attaching a patch that replaces these 'QMessageBox'es with simple std::cerr.

This patch also reduces the GUI update delay from 100ms to 32ms, which makes the white line move a lot smoother. It also removes the annoying "The subtitles" tooltip at main QTable.

Finally, I also moved the calculations that were previously done inside critical area (inside mutex lock). I think any program should stay in locked state as little as possible, so I moved them to just before or after the lock.

I still did not have enough time to test this patch, but I guess it should work without many problems.

Discussion