#2 Missing a call to get_mod_name in delete_module ...

closed
nobody
None
5
2005-10-25
2003-12-10
Anonymous
No

Hi all,
This is really a problem in some conditions,
in StMichael_syscall_delete_module, you use name "as
is" but you must use the get_mod_name function to avoid
craps and being discovered / remove.
So at the begining of your syscall, just add a call to
get_mod_name and made the rest with the getted value.
I didn't check all the others part of the module, but
not doing this is clealy a big problem because you
remove a module delete_module find it and then it is
not remove from the module_list (in Stm) so It's
detecting a covert try and kill the kernel :(.

Hope that somebody read this one day :)
Contact : same as the previous bug reports :)

Discussion

  • Logged In: YES
    user_id=951033

    Yeah,

    You have the reason... i seen it all times i do a hack into
    delete_module
    system call...

    Maybe the best way to solve this situation is using a
    sys_mycall like function to prepar the module to be removed
    (and then, move back the original system call and hacks).

    I have send a mail to lawless to talk if i can contribute in
    the development process, and then ill fix this bug...

    Thank you,

    Rodrigo Rubira Branco
    (BSDaemon)

     
    • status: open --> closed
     
  • Logged In: YES
    user_id=951033

    Please, test it against the newest version of StMichael (0.12).