On 21/07/2010 19:21, Pep i Mercè Mas la Roca wrote:
Hi Peter.

I've seen you have added a branch to fix this bug. Apparently it's not a bug, but if you try to change the seconds when the time is paused (timerate=0) really don't work: It's very difficult to modify correctly the numbers and the spinner up work sometimes (if you repeat the 'seconds' spinner up few times finally it's ignored). Also if you modify the hours or minutes, the seconds are changed randomly.

I think that the next code fix it:

Run command: bzr diff

=== modified file 'src/gui/StelGui.cpp'

--- src/gui/StelGui.cpp 2010-05-31 10:10:36 +0000

+++ src/gui/StelGui.cpp 2010-07-20 16:54:26 +0000

@@ -684,7 +684,7 @@

skyGui->updateBarsPos();

}

- if (dateTimeDialog.visible())

+ if (dateTimeDialog.visible() && nav->getTimeRate()!=0)

dateTimeDialog.setDateTime(nav->getJDay());

}



If you confirm my theory, will you add the fix to your branch?

Pep.

Thanks for that Pep.  As it happens, my patch already fixes the problem when time is stopped, so no further changes required.  Two bugs for the price of one patch - do I get paid double?  (just don't tell anyone that it was only good luck - my patch prevents update of the seconds value when it is selected, which is why it also works for your issue.)

As for the seconds changing when the user alters the hours or minutes, that's a separate bug - I've created a bug report and posted a patch.

Thanks again,
Peter