#7 srf2fastq.c: When calling usage() exit with status 1

Accepted
closed-accepted
None
5
2010-01-07
2010-01-07
Jordan Mendler
No

Hopefully this is acceptable. Seems to make more sense to exit with non-zero exit status when usage() is displayed due to --help or improper syntax.

Exit status 0 implies there are no problems, so our pipeline cannot detect if srf2fastq exited successfully or if it exited due to an invalid parameter.

Any thoughts?

Discussion

  • James Bonfield
    James Bonfield
    2010-01-07

    Agreed. Patch applied in SVN.

     
  • James Bonfield
    James Bonfield
    2010-01-07

    • milestone: --> Accepted
    • assigned_to: nobody --> jkbonfield
    • status: open --> closed-accepted