#201 mark_read plugin: correction

closed-fixed
nobody
None
5
2008-08-22
2008-08-21
Roberto Piola
No

while installing mark_read plugin version 1.42 in Squirrelmail 1.4.15, I noticed that, at the end of mar_read.php, there was a worng redirtection (well: it possibly worked in some enviroment, where squirrelmail is installed in a subdirectory, not in our environment where it is installed at top level.

I corrected the code. here is the new file and the diff against the original one

Discussion

  • Roberto Piola
    Roberto Piola
    2008-08-21

    the corrected plugins/mark_read/mark_read.php

     
    Attachments
  • Roberto Piola
    Roberto Piola
    2008-08-21

    diff against the official 1.4.2 version

     
    Attachments
  • Roberto Piola
    Roberto Piola
    2008-08-21

    Logged In: YES
    user_id=2107494
    Originator: YES

    File Added: mark_read.php.diff

     
    • status: open --> closed-fixed
     
  • Logged In: YES
    user_id=508228
    Originator: NO

    Thank you, but please be aware:

    - This plugin has more issues than just that. I have a new revision with many fixes, including this in beta testing. If you'd like a copy (feedback apprecaited), please contact me privately

    - Please use unified diff format.

    - The correct solution is not to use $base_uri. Instead, get_location() is the correct code to use in header redirects.

    - The SquirrelMail tracker is not for tracking third party software. Please contact the plugin authors directly and, if you like, notify the squirrelmail-plugins mailing list.

    Thanks for your interest and help!