#79 Fix for case-sensitive $HTTPS check on SSL servers

closed
nobody
None
5
2001-01-15
2001-01-11
No

I'm trying out squirrelmail Version 1.0pre1 on a Linux install of Apache (IBM_HTTP_Server/1.3.6.2 Apache/1.3.7-dev) using PHP 4.0.2 compiled as a module. The value for the php apache environment variable HTTPS variable is returned in uppercase. I'm not sure this is the case across all distributions and packages but for me, the value is returned as 'ON' when using SSL. Since the get_location() function in the functions/strings.php uses a case sensitive check on the value of HTTPS when determining how to rebuild the URL it breaks the SSL connection when it returns http://www.server.com:443/dir/ instead of https://www.server.com/dir/.

I fixed this problem by using a case-insensitive string comparison when checking to see if the value of $HTTPS is 'on'.

I thought I'd let you know so it doesn't break when I update from CVS the next time... ;) Thanks for a great package by the way. You may here more from me as I work through it and begin to use it a bit.

Forrest R. Stevens
squirrelmail@forreststevens.com

Discussion

  • None

     
    Attachments
  • Tyler Akins
    Tyler Akins
    2001-01-15

    Added to CVS.

     
  • Tyler Akins
    Tyler Akins
    2001-01-15

    • status: open --> closed