From: Paul L. <pa...@sq...> - 2008-03-14 10:05:17
|
On Sat, Mar 8, 2008 at 3:50 AM, Fredrik Jervfors <jer...@sq...> wrote: > >>>> Revision: 13013 > >>>> > >>>> Log Message: > >>>> ----------- > >>>> Viewing unsafe images is a core functionality, so I remove these > >>>> comments. > >>> > >>> I didn't remove all the FIXMEs in this commit. Any comments on the > >>> ones that are left? > >>> > >>> http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/branches/ > >>> SM-1_4-STABLE/squirrelmail/functions/mime.php?r1=12931&r2=13013 > >> > >> The diffs at lines 313, 1702 and 2331 talk about prefs but the code > >> the comments appear above has nothing to do with prefs. > >> > >>> http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/branches/ > >>> SM-1_4-STABLE/squirrelmail/src/read_body.php?r1=12954&r2=13013 > >> > >> Same here > >> > >>> http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/trunk/squ > >>> irrelmail/functions/mime.php?r1=12930&r2=13013 > >>> http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/trunk/squ > >>> irrelmail/src/read_body.php?r1=12951&r2=13013 > >> > >> Same with some of the stuff here, too. I think it should be the > >> person who wrongly committed the comments to find the ones that need to > >> be corrected. ;-) > > > > "I get by with a little help from my friends." Open source is partly > > about correcting others mistake. > > > > When I took another look I see what you mean. I'll fix it ASAP. I just > > wasn't in the mood to rewrite stuff at 4 o'clock in the morning (might > > even have made things worse). > > http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/branches/SM-1_4-STABLE/squirrelmail/functions/mime.php?r1=12931&r2=13019 > http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/branches/SM-1_4-STABLE/squirrelmail/src/read_body.php?r1=12954&r2=13019 > http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/trunk/squirrelmail/functions/mime.php?r1=12930&r2=13019 > http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/trunk/squirrelmail/src/read_body.php?r1=12951&r2=13019 > > What about this then? All seem alright to me - at least w/out having reading much of the code to which the comments apply and just focusing on the problem from before. |